feat(react): add tutorial nav data to index #11631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joshblack
approved these changes
Jun 16, 2022
mattrosno
reviewed
Jun 16, 2022
francinelucca
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
this LGTM.
@alisonjoseph in our docs we have specified the navData path has to be relative to the carbon.yml; I see how that's not possible here, should we update our docs/schema to allow both absolute and relative urls?
|
@francinelucca good catch, I'll make an issue and update docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #carbon-design-system/carbon-platform#888
Add navData to Carbon React library for tutorial pages
(keeping MDX source in carbon-website repository for now, in the future docs will be stored alongside components)
Changelog
Changed
Testing / Reviewing
Ensure data matches schema
https://github.com/carbon-design-system/carbon-platform/blob/main/docs/resource-schemas.md#resource-schemas