Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update usage path docs to allow absolute url #901

Merged
merged 2 commits into from
Jun 21, 2022
Merged

docs: update usage path docs to allow absolute url #901

merged 2 commits into from
Jun 21, 2022

Conversation

alisonjoseph
Copy link
Member

Closes #900
Update library schema docs to allow both relative and absolute urls in navData

@alisonjoseph alisonjoseph requested a review from a team as a code owner June 21, 2022 15:46
@alisonjoseph alisonjoseph mentioned this pull request Jun 21, 2022
Merged
francinelucca
francinelucca requested changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs LGTM, let's update packages/schemas as well? (internal/validation/* and carbon-resources.schema.json)
image
image

@alisonjoseph
Copy link
Member Author

updated @francinelucca

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

andreancardona
andreancardona approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

francinelucca
francinelucca approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@alisonjoseph alisonjoseph merged commit f8da271 into main Jun 21, 2022
@alisonjoseph alisonjoseph deleted the schema-docs-900 branch June 21, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@andreancardona andreancardona andreancardona approved these changes

@jharvey10 jharvey10 Awaiting requested review from jharvey10 jharvey10 is a code owner automatically assigned from carbon-design-system/carbon-platform-devs

@mattrosno mattrosno Awaiting requested review from mattrosno

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update scheme docs to allow for absolute and relative urls for library navData
3 participants
@alisonjoseph @andreancardona @francinelucca