Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): emit component tokens in zones #11227

Conversation

joshblack
Copy link
Contributor

Closes #11180

This PR updates our zone strategy to emit component tokens. This will unfortunately emit all component tokens but we could update this to conditionally include based on usage in the future. The core challenge is that if we want to include component tokens based on usage this import must happen after components are included in order for them to be registered appropriately.

Changelog

New

Changed

  • Update _zone.scss to emit component tokens

Removed

Testing / Reviewing

  • Verify the Theme story in Storybook emits component tokens for button, tag, and notification

@joshblack joshblack requested a review from a team as a code owner April 13, 2022 17:57
@joshblack joshblack requested review from tay1orjones and dakahn April 13, 2022 17:57
@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4d02c5d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/625dbd959f2c9f000802c9d2
😎 Deploy Preview https://deploy-preview-11227--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4d02c5d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/625dbd961f141b00086d114e
😎 Deploy Preview https://deploy-preview-11227--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@joshblack
Copy link
Contributor Author

bump @tay1orjones when you get a sec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add component tokens to zones / inline themes
3 participants