-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): live demo fixes #2925
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@joshblack update the PR 👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! 💪 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Sorry it took me so long to review
Closes carbon-design-system/carbon#11267
rel: carbon-design-system/carbon#11157
rel: carbon-design-system/carbon#11227
rel: #2899
rel: carbon-design-system/carbon#11164
Changelog
theme
mixinIconButton
knobs bc there's no docgen for it (need to figure out how to rebuild docgen or manually add it)iconOnly
className toIconButton
live demo (these styles are off in React. I have a PR up to fix so this can be removed when the fix is released). Rel: fix(IconButton): addshasIconOnly
classname to fix right padding carbon#11352Testing
Test the button live demo in both the
Usage
tab andCode
tab for the following:IconButton