Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Button): live demo fixes #2925

Merged
merged 6 commits into from
May 16, 2022

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented May 5, 2022

Closes carbon-design-system/carbon#11267
rel: carbon-design-system/carbon#11157
rel: carbon-design-system/carbon#11227
rel: #2899
rel: carbon-design-system/carbon#11164

Changelog

  • includes component tokens for theme mixin
  • temporarily removes IconButton knobs bc there's no docgen for it (need to figure out how to rebuild docgen or manually add it)
  • temporarily adds iconOnly className to IconButton live demo (these styles are off in React. I have a PR up to fix so this can be removed when the fix is released). Rel: fix(IconButton): adds hasIconOnly classname to fix right padding carbon#11352
  • removes contextual layer tokens that were added as a temporary override a while back

Testing

Test the button live demo in both the Usage tab and Code tab for the following:

  • working IconButton
  • working size knobs
  • working g90/g100 themes for: secondary, tertiary, ghost, danger & disabled btn (previously tokens weren't updating so color was off)

@vercel
Copy link

vercel bot commented May 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
carbondesignsystem ✅ Ready (Inspect) Visit Preview May 16, 2022 at 7:33PM (UTC)

@joshblack
Copy link
Contributor

Looks great! Only thing I noticed was the text color in the disabled state on dark themes:

image

Is this covered by this PR or is that in a separate issue?

@jnm2377
Copy link
Contributor Author

jnm2377 commented May 11, 2022

@joshblack update the PR 👍🏽

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 💪 🎉

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry it took me so long to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Button live demo
5 participants