Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): update theme and switch theme icon #10593

Merged

Conversation

joshblack
Copy link
Contributor

Closes #9825

This PR fixes our contrast issues with the two global toolbar items by reverting our theme changes (we would need to revisit them anyways for v11 tokens) and replaces the theme switcher icon with the paintbrush asset from Storybook

Changelog

New

Changed

  • Revert theme to default storybook colors for contrast issues
  • Update icon to paintbrush

Removed

Testing / Reviewing

  • Verify the "toolbar icons" render correctly and have a visible style

@joshblack joshblack requested a review from a team as a code owner January 31, 2022 21:49
@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 8d2b17c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61fd94b856f8c20008c2b2f3

😎 Browse the preview: https://deploy-preview-10593--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 8d2b17c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fd94b8cc3b6b00075f260b

😎 Browse the preview: https://deploy-preview-10593--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 8d2b17c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61fd94b8cf993900078fab56

😎 Browse the preview: https://deploy-preview-10593--carbon-elements.netlify.app

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can actually see the buttons now! Haha looks great to me!

@kodiakhq kodiakhq bot merged commit c4329f8 into carbon-design-system:main Feb 4, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 10, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update @carbon/react storybook theme switcher dropdown icon
3 participants