Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @carbon/react storybook theme switcher dropdown icon #9825

Closed
tay1orjones opened this issue Oct 8, 2021 · 3 comments · Fixed by #10593
Closed

Update @carbon/react storybook theme switcher dropdown icon #9825

tay1orjones opened this issue Oct 8, 2021 · 3 comments · Fixed by #10593
Assignees
@joshblack
Labels
role: dev 🤖 type: docs 📖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11

Comments

@tay1orjones
Copy link
Member

The theme switcher dropdown currently is just a blank round icon. This appears to be a default from storybook. I think this is something we should be able to customize.

image

Ideally the icon button used to invoke the dropdown would be our color palette icon
@joshblack
Copy link
Contributor

I think we're currently using: https://storybook.js.org/docs/react/essentials/toolbars-and-globals#global-types-and-the-toolbar-annotation which only allows these icons: https://storybook.js.org/docs/react/faq#what-icons-are-available-for-my-toolbar-or-my-addon

@joshblack joshblack mentioned this issue Jan 4, 2022
Closed
46 tasks
@tay1orjones
Copy link
Member Author

tay1orjones commented Jan 31, 2022 •
edited
Loading

Some potential candidates:

image image image

@joshblack
Copy link
Contributor

I went with paintbrush since mirror was already in use 👀

@joshblack joshblack self-assigned this Jan 31, 2022
@joshblack joshblack mentioned this issue Jan 31, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #10593 Feb 4, 2022
kennylam pushed a commit to kennylam/carbon that referenced this issue Jul 30, 2024
@annawen1
fix(progress-indicator): add missing import for progress indicator sk…
69a0f48 
…eleton (carbon-design-system#9853)

### Related Ticket(s)

[BX Progress Indicator Skeleton]: Vue: Unknown custom element: <bx-progress-indicator-skeleton> carbon-design-system#9825

### Description

For adopter using `import "@carbon/web-components/es/components/progress-indicator/index.js"` and `bx-progress-indicator-skeleton` there is an error. Seems adding the missing import to the `index.js` file should resolve the issue.

### Changelog

**New**

- add import for `progress-indicator-skeleton` in the index.js file

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshblack joshblack

Labels
role: dev 🤖 type: docs 📖 type: enhancement 💡 version: 11 Issues pertaining to Carbon v11
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(storybook): update theme and switch theme icon joshblack/carbon
2 participants
@tay1orjones @joshblack