-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(react): updated storybook to use new prop to fix headers a11y issue #10547
docs(react): updated storybook to use new prop to fix headers a11y issue #10547
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 0534fe3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61fab65faf4635000707cd57 😎 Browse the preview: https://deploy-preview-10547--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 2ae95ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f2fe2999584300085f8849 😎 Browse the preview: https://deploy-preview-10547--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 2ae95ee 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f2fe294dbbde00083cb432 😎 Browse the preview: https://deploy-preview-10547--carbon-components-react.netlify.app/ |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 0534fe3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fab65f5ae6a70009db09f1 😎 Browse the preview: https://deploy-preview-10547--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 0534fe3 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61fab65fb426d500075c8e1e 😎 Browse the preview: https://deploy-preview-10547--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Closes #10167
#10167 (comment)
I recently did this a11y fix here #10214 but forgot to add the changes into the storybook (or maybe I added them to the wrong part of the storybook) so this is the storybook fix for this a11y issue
Changelog
Changed
Added the id prop to the
TableExpandHeader
component for the expanding data tables to match up with theTableExpandRow
defaultsexpandHeader
props default valueTesting / Reviewing
Ran the IBM a11y tool on the storybook locally for each expanding table and did not see the issue. I also checked the html to be sure the id's got added and matched the headers attribute