Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(react): updated storybook to use new prop to fix headers a11y issue #10547

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Jan 27, 2022

Closes #10167

#10167 (comment)

I recently did this a11y fix here #10214 but forgot to add the changes into the storybook (or maybe I added them to the wrong part of the storybook) so this is the storybook fix for this a11y issue

Changelog

Changed

Added the id prop to the TableExpandHeader component for the expanding data tables to match up with the TableExpandRow defaults expandHeader props default value

Testing / Reviewing

Ran the IBM a11y tool on the storybook locally for each expanding table and did not see the issue. I also checked the html to be sure the id's got added and matched the headers attribute

@TannerS TannerS requested a review from a team as a code owner January 27, 2022 20:18
@TannerS TannerS requested review from aledavila and dakahn January 27, 2022 20:18
@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0534fe3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61fab65faf4635000707cd57

😎 Browse the preview: https://deploy-preview-10547--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 2ae95ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f2fe2999584300085f8849

😎 Browse the preview: https://deploy-preview-10547--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 2ae95ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f2fe294dbbde00083cb432

😎 Browse the preview: https://deploy-preview-10547--carbon-components-react.netlify.app/

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 0534fe3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fab65f5ae6a70009db09f1

😎 Browse the preview: https://deploy-preview-10547--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 27, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0534fe3

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61fab65fb426d500075c8e1e

😎 Browse the preview: https://deploy-preview-10547--carbon-elements.netlify.app

Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: The 'headers' attribute value "expand" does not reference a valid 'id' in this document
3 participants