Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] [A11y] headers="expand" should be removed from first column <td> #3485

Closed
1 task done
valZho opened this issue Jun 23, 2022 · 2 comments · Fixed by #3611
Closed
1 task done

[Table] [A11y] headers="expand" should be removed from first column <td> #3485

valZho opened this issue Jun 23, 2022 · 2 comments · Fixed by #3611
Assignees
Labels
dependent on: carbon Items present upstream in Carbon Design System severity: 2 Affects major functionality, has a workaround type: bug 🐛

Comments

@valZho
Copy link

valZho commented Jun 23, 2022

What package is this for?

  • React
  • [?] Angular

Describe the bug

The 'headers' attribute with value "expand" does not reference a valid 'id' in the document

Expected behavior

The tags for the first column (row expansion) in a table contain the property header="expand" which is supposed to point to the id of a cell, but none of the elements have ids (let alone something so generic). The header property should be removed.

Environment/versions:

  • carbon-addons-iot-react version: 2.150.0

Additional context

Screen Shot 2022-06-23 at 3 16 44 PM

@JordanWSmith15 JordanWSmith15 added the severity: 2 Affects major functionality, has a workaround label Jun 28, 2022
@davidicus
Copy link
Collaborator

This attribute is coming from Carbon. After looking into their own issue for this the fix is to add id to their TableHeader component as they have done in this PR

@jessieyan
Copy link
Collaborator

jessieyan commented Oct 19, 2022

On next branch, I can still see headers='expand' on the TableExpandRow with no id. I can still see the a11y violations.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent on: carbon Items present upstream in Carbon Design System severity: 2 Affects major functionality, has a workaround type: bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants