-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TableHead): add id prop on TableExpandHeader #3611
Conversation
✅ Deploy Preview for carbon-addons-iot-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ai-apps-pal-angular ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Brought it to scrum today. We will use |
Closes #3485
Summary
TableExpandHeader
According to the rule H43: Using id and headers attributes to associate data cells with header cells in data tables
Header should use
id
prop for the any table cell to reference with. The default header for the first cell inTableExpandRow
is set toheaders='expand'
. But we did not set anid
onTableExpandHeader
for the cell to refer to.The solution is to set
id={
${tableId}-expand}
onTableExpandHeader
andexpandHeader={
${tableId}-expand}
onTableExpandRow
:Change List (commits, features, bugs, etc)
-fix(TableBodyRow): add id prop on TableExpandHeader
Acceptance Test (how to verify the PR)
'The 'headers' attribute value "expand" does not reference a valid 'id' in this document'
before:
after:
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.