revert(button): revert changes to button for v11

[joshblack]

Closes #10505
Closes #10294

This PR reverts the changes we made to button for icon support. This should address most of the issues with components using Button as an icon button.

Changelog

New

Changed

• Revert changes to button to mirror v10 behavior

Removed

Testing / Reviewing

• Verify issues identified in referenced issues have been resolved
• Verify IconButton still works as intended

[netlify]

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e79b81e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f18683182200000850e94e

😎 Browse the preview: https://deploy-preview-10510--carbon-react-next.netlify.app

[netlify]

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e79b81e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f18683510f0e00070830ff

😎 Browse the preview: https://deploy-preview-10510--carbon-elements.netlify.app

[netlify]

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e79b81e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f18683cdf15a0008530851

😎 Browse the preview: https://deploy-preview-10510--carbon-components-react.netlify.app

[tay1orjones]

This also fixes the Pagination forward/back buttons issue @tw15egan discovered today

[jnm2377]

I can see the buttons now, but they still have some weird alignment issues with the icons.

[joshblack]

@jnm2377 good spot, thanks for catching that. It seems like our reset helper has changed a bit and now will set display: block 🤔

Let me go and update that real quick!

[jnm2377]

LGTM 👍🏽

[tw15egan]

@joshblack noticing that the tooltips do not appear when hovering over Icon buttons (noticed in Pagination). Is this new behavior intentional?

[joshblack]

@tw15egan great catch, this is currently coming up because we are not including the tooltip styles in v11 and are trying to supplement them with popover/icon button usage.

I think this is something that we can ship as a known issue and use the next couple of sprints to either:

• Restore the tooltip styles for button tooltips
• Update our internal usage of Button to use the new IconButton
• Some other option??? lol

Let me know what you think!

[tw15egan]

@joshblack gotcha! I see that they are working as intended in the v10 source just not in v11. I think option 2 makes the most sense going forward in the v11 source.