Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify areas where Button#hasIconOnly is used and determine replacement #10294

Closed
joshblack opened this issue Dec 15, 2021 · 0 comments · Fixed by #10510
Closed

Identify areas where Button#hasIconOnly is used and determine replacement #10294

joshblack opened this issue Dec 15, 2021 · 0 comments · Fixed by #10510
Labels
package: @carbon/react @carbon/react type: bug 🐛

Comments

@joshblack
Copy link
Contributor

We are running into a number of situations that come in response to us removing part of the icon functionality from Button that we need to figure out the response for. In particular, buttons that only render an icon are no longer appearing as intended.

Areas that are impacted so far:
@joshblack joshblack moved this to ⏱ Backlog in Design System Dec 15, 2021
@joshblack joshblack mentioned this issue Jan 24, 2022
Merged
@kodiakhq kodiakhq bot closed this as completed in #10510 Jan 26, 2022
Repository owner moved this from ⏱ Backlog to ✅ Done in Design System Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: @carbon/react @carbon/react type: bug 🐛
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert(button): revert changes to button for v11 joshblack/carbon
1 participant
@joshblack