Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): update size prop types for v11 #10509

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

sstrubberg
Copy link
Member

@sstrubberg sstrubberg commented Jan 24, 2022

REF #10295

  • Added a v11 flag for the size prop to only accept SM, MD, LG. REF. The v10 version will accept SM, MD, LG and XL.
  • Added 'md' as a default for the size prop.
  • Added 'false' as a default for the disabled prop for better documentation in Storybook.
  • Removed defaultProps for align prop and made it a default param. Updated the PubicAPI snapshot accordingly.
  • Added a story for the v11 Storybook so I could see the changes.

Testing

  • Make sure everything is snappy in the v11 Storybook and that everything I'm saying above is true.

Something kind of annoying is that when I use the v11 flag in-line with the PropTypes, you'll notice the "custom" values. Not sure if anything can be done about that.
image

@sstrubberg sstrubberg requested review from a team as code owners January 24, 2022 20:39
@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 07fce47

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f02cdc3854f000076b52be

😎 Browse the preview: https://deploy-preview-10509--carbon-react-next.netlify.app

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

One quick note, you may not need to include an Accordion.stories.js file after: #10500 gets merged in as it should pick up Accordion-story.js in our next storybook 🎉

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 07fce47

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f02cdc9669dc0007491ebb

😎 Browse the preview: https://deploy-preview-10509--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 07fce47

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f02cdc366fec000815932f

😎 Browse the preview: https://deploy-preview-10509--carbon-components-react.netlify.app

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joshblack joshblack changed the title chore(Accordion): updated size prop types feat(accordion): update size prop types for v11 Jan 25, 2022
@sstrubberg sstrubberg enabled auto-merge (squash) January 25, 2022 17:03
@sstrubberg sstrubberg merged commit 1fcc0f6 into carbon-design-system:main Jan 25, 2022
@sstrubberg sstrubberg deleted the size-audit-accordion branch January 25, 2022 18:45
@abbeyhrt abbeyhrt mentioned this pull request Jan 27, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants