-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion): update size prop types for v11 #10509
feat(accordion): update size prop types for v11 #10509
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 07fce47 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f02cdc3854f000076b52be 😎 Browse the preview: https://deploy-preview-10509--carbon-react-next.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
One quick note, you may not need to include an Accordion.stories.js
file after: #10500 gets merged in as it should pick up Accordion-story.js
in our next storybook 🎉
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 07fce47 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f02cdc9669dc0007491ebb 😎 Browse the preview: https://deploy-preview-10509--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 07fce47 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f02cdc366fec000815932f 😎 Browse the preview: https://deploy-preview-10509--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
REF #10295
size
prop to only accept SM, MD, LG. REF. The v10 version will accept SM, MD, LG and XL.size
prop.disabled
prop for better documentation in Storybook.align
prop and made it a default param. Updated the PubicAPI snapshot accordingly.Testing
Something kind of annoying is that when I use the v11 flag in-line with the PropTypes, you'll notice the "custom" values. Not sure if anything can be done about that.