-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(carbon-react): update glob pattern to include missing stories #10500
docs(carbon-react): update glob pattern to include missing stories #10500
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: bd8672d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f312fde3a3510007d5dc55 😎 Browse the preview: https://deploy-preview-10500--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: bd8672d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f312fd86d3be00073a1f5a 😎 Browse the preview: https://deploy-preview-10500--carbon-components-react.netlify.app |
…at/add-react-story
…fork into feat/add-react-story
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 2b7c182 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61eb3c8372a54400070e57d3 😎 Browse the preview: https://deploy-preview-10500--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: bd8672d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f312fd64f93400071e5ba3 😎 Browse the preview: https://deploy-preview-10500--carbon-elements.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The story order appears to be wrong, but otherwise I think this looks solid 👍
@@ -130,6 +130,9 @@ export const parameters = { | |||
}, | |||
}, | |||
}, | |||
options: { | |||
method: 'alphabetical', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One quick question, is it possible to bring over the custom storySort
function that we use in packages/react
? 👀
Pull Request is not mergeable
Closes #10485
Updates
carbon-react
storybook to include all stories frompackages/react
but prefer thenext/*.stories.js
if it exists.Changelog
New
*-story.js
stories in v11 storybookChanged
Testing / Reviewing
Verify that all components have stories in v11 and that for components that have both a
/next/*.stories.js
file and a*-story,js
file, thenext
story file takes is what appears (for example: Tabs, TextArea, Toggle, Button, Combobox, to name a few).