Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(carbon-react): update glob pattern to include missing stories #10500

Merged
merged 16 commits into from
Jan 27, 2022
Merged

docs(carbon-react): update glob pattern to include missing stories #10500

merged 16 commits into from
Jan 27, 2022

Conversation

abbeyhrt
Copy link
Contributor

Closes #10485

Updates carbon-react storybook to include all stories from packages/react but prefer the next/*.stories.js if it exists.

Changelog

New

  • *-story.js stories in v11 storybook

Changed

  • Alphabetizes stories

Testing / Reviewing

Verify that all components have stories in v11 and that for components that have both a /next/*.stories.js file and a *-story,js file, the next story file takes is what appears (for example: Tabs, TextArea, Toggle, Button, Combobox, to name a few).

@abbeyhrt abbeyhrt requested a review from a team as a code owner January 21, 2022 23:06
@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: bd8672d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61f312fde3a3510007d5dc55

😎 Browse the preview: https://deploy-preview-10500--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: bd8672d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61f312fd86d3be00073a1f5a

😎 Browse the preview: https://deploy-preview-10500--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 2b7c182

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61eb3c8372a54400070e57d3

😎 Browse the preview: https://deploy-preview-10500--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 22, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: bd8672d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61f312fd64f93400071e5ba3

😎 Browse the preview: https://deploy-preview-10500--carbon-elements.netlify.app

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The story order appears to be wrong, but otherwise I think this looks solid 👍

@@ -130,6 +130,9 @@ export const parameters = {
},
},
},
options: {
method: 'alphabetical',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to do this via a storySort function instead. The current order appears to be alphabetical per glob order, maybe? I'm not sure, but you can see Button stories aren't next to Breadcrumb in the current v11 deploy preview.

Click to expand screenshot

Screen Shot 2022-01-24 at 10 25 17 AM

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One quick question, is it possible to bring over the custom storySort function that we use in packages/react? 👀

@joshblack joshblack enabled auto-merge (squash) January 27, 2022 19:03
auto-merge was automatically disabled January 27, 2022 21:36

Pull Request is not mergeable

@kodiakhq kodiakhq bot merged commit 87cdcb2 into carbon-design-system:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify all stories appear in v11 storybook
5 participants