Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react): update InlineCheckbox to FC #10363

Merged
merged 4 commits into from
Jan 11, 2022
Merged

refactor(react): update InlineCheckbox to FC #10363

merged 4 commits into from
Jan 11, 2022

Conversation

joshblack
Copy link
Contributor

Reference #10281

This PR updates our InlineCheckbox internal component to a Functional Component.

Changelog

New

Changed

  • Update InlineCheckbox to FC

Removed

Testing / Reviewing

  • Verify all places where InlineCheckbox is used work as expected in storybook and in tests
    • TableSelectRow
    • TableSelectAll
  • Verify tests pass as expected
  • Verify component refactor matches our style guidelines

@joshblack joshblack requested a review from a team as a code owner January 7, 2022 18:14
@netlify
Copy link

netlify bot commented Jan 7, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: b13b05c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61ddfe996c0cf30007512edb

😎 Browse the preview: https://deploy-preview-10363--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jan 7, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: b13b05c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61ddfe998ab999000954b19a

😎 Browse the preview: https://deploy-preview-10363--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 7, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: b13b05c

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61ddfe99c61f3f000856cf10

😎 Browse the preview: https://deploy-preview-10363--carbon-components-react.netlify.app

tw15egan
tw15egan approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as expected 👍🏻 ✅

aledavila
aledavila approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great

@kodiakhq kodiakhq bot merged commit 9f143a3 into carbon-design-system:main Jan 11, 2022
@abbeyhrt abbeyhrt mentioned this pull request Jan 14, 2022
Closed
22 tasks
@tay1orjones tay1orjones mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@tw15egan tw15egan tw15egan approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @tay1orjones @tw15egan @aledavila