Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expandable-tile): onClick is called twice for ExpandableTile #10358

Merged
merged 7 commits into from
Jan 13, 2022
Merged

fix(expandable-tile): onClick is called twice for ExpandableTile #10358

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
456a33c
fix onClick is called twice for ExpandableTile
yaoterry Jan 7, 2022
a83b6e1
Merge branch 'main' into fix_ExpandableTile_onClick
kodiakhq[bot] Jan 10, 2022
8087895
fix(ExpandableTile): fix lint
yaoterry Jan 11, 2022
f3c0b80
Merge branch 'fix_ExpandableTile_onClick2' into fix_ExpandableTile_on…
yaoterry Jan 11, 2022
76c9188
Merge branch 'main' into fix_ExpandableTile_onClick
kodiakhq[bot] Jan 11, 2022
9e98d10
Merge branch 'main' into fix_ExpandableTile_onClick
yaoterry Jan 13, 2022
ca0752d
Merge branch 'main' into fix_ExpandableTile_onClick
kodiakhq[bot] Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/react/src/components/Tile/Tile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ export class ExpandableTile extends Component {
*/
handleClick: deprecate(
PropTypes.func,
'The handleClick prop for ClickableTile has been deprecated in favor of onClick. It will be removed in the next major release.'
'The handleClick prop for ExpandableTile has been deprecated in favor of onClick. It will be removed in the next major release.'
),

/**
Expand Down Expand Up @@ -629,8 +629,6 @@ export class ExpandableTile extends Component {
expanded, // eslint-disable-line
tileMaxHeight, // eslint-disable-line
tilePadding, // eslint-disable-line
handleClick, // eslint-disable-line
onClick,
onKeyUp,
tileCollapsedIconText,
tileExpandedIconText,
Expand Down Expand Up @@ -676,7 +674,7 @@ export class ExpandableTile extends Component {
title={isExpanded ? tileExpandedIconText : tileCollapsedIconText}
{...rest}
onKeyUp={composeEventHandlers([onKeyUp, this.handleKeyUp])}
onClick={composeEventHandlers([onClick, this.handleClick])}
onClick={this.handleClick}
tabIndex={tabIndex}>
<div
ref={(tileContent) => {
Expand Down