Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expandable-tile): onClick is called twice for ExpandableTile #10358

Merged
merged 7 commits into from
Jan 13, 2022
Merged

fix(expandable-tile): onClick is called twice for ExpandableTile #10358

merged 7 commits into from
Jan 13, 2022

Conversation

yaoterry
Copy link
Contributor

@yaoterry yaoterry commented Jan 7, 2022 •
edited
Loading

Closes #10359
fix the carbon ExpandableTile component onClick callback is called twice.

Changelog

New

N/A

Changed

make the onClick is only called once.

Removed

N/A

Testing / Reviewing

@yaoterry yaoterry requested a review from a team as a code owner January 7, 2022 04:59
@netlify
Copy link

netlify bot commented Jan 7, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ca0752d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61df968c97409f0008ca3dfd

😎 Browse the preview: https://deploy-preview-10358--carbon-react-next.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify
Copy link

netlify bot commented Jan 7, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ca0752d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61df968cf401a700078e8450

😎 Browse the preview: https://deploy-preview-10358--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 7, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ca0752d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61df968c4bb0ba000863c142

😎 Browse the preview: https://deploy-preview-10358--carbon-components-react.netlify.app

@yaoterry yaoterry changed the title fix onClick is called twice for ExpandableTile fix(expanable-tile): onClick is called twice for ExpandableTile Jan 7, 2022
@yaoterry yaoterry changed the title fix(expanable-tile): onClick is called twice for ExpandableTile fix(expandable-tile): onClick is called twice for ExpandableTile Jan 7, 2022
@yaoterry
Copy link
Contributor Author

yaoterry commented Jan 7, 2022

I have read the DCO document and I hereby sign the DCO.

@kodiakhq kodiakhq bot merged commit ee07256 into carbon-design-system:main Jan 13, 2022
TannerS pushed a commit to TannerS/carbon that referenced this pull request Jan 13, 2022
@yaoterry @kodiakhq @TannerS
fix(expandable-tile): onClick is called twice for ExpandableTile (car…
95c7d38 
…bon-design-system#10358)

* fix onClick is called twice for ExpandableTile

* fix(ExpandableTile): fix lint

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: onClick prop of the ExpandableTile is called twice
3 participants
@yaoterry @joshblack @dakahn