Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus order for overflow menu is not working. #910

Closed
kavyanekkalapu opened this issue Jun 19, 2018 · 2 comments
Closed

Focus order for overflow menu is not working. #910

kavyanekkalapu opened this issue Jun 19, 2018 · 2 comments

Comments

@kavyanekkalapu
Copy link
Contributor

kavyanekkalapu commented Jun 19, 2018

Our team is working on accessibility testing(AVT) issues and we noticed issue with overflow menu component.

Issue: On tabbing to Overflow menu and pressing enter, the list of options are displayed. On tabbing to last option , when user tabs further, the focus moves to title of the page. This focus order is not meaningful. On tabbing, either the focus should move to the next interactive element on the page or the focus should keep moving within the same section of the list item

I observed same issue http://www.carbondesignsystem.com/components/overflow-menu/code and
http://www.carbondesignsystem.com/components/data-table/code.

Note: Issue does not exist in http://react.carbondesignsystem.com/?selectedKind=OverflowMenu&selectedStory=basic&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel.

For more info : https://ibm.enterprise.slack.com/files/W4FRVREA1/FB9LQG9C2/overflowmenu-focus.mov

@kavyanekkalapu
Copy link
Contributor Author

kavyanekkalapu commented Jun 19, 2018

One observation is, when i inspect options in overflow menu, ul and li elements are displaying at bottom of the page, so even if i keep tab order, it is not useful as it seems , that is the end of the page.
Where as in react components, ul and li elements are displaying along overflow component div.

screen shot 2018-06-19 at 10 38 13 am

screen shot 2018-06-19 at 10 38 01 am

react screenshot:

screen shot 2018-06-19 at 10 38 58 am

Hope this helps in fixing the issue, thanks.

@asudoh
Copy link
Contributor

asudoh commented Jun 20, 2018

Thank you @kavyanekkalapu for reporting. Looks a good one and we’ll see what we can do.

asudoh added a commit to asudoh/carbon-components-react that referenced this issue Jun 28, 2018
This change makes `<FloatingMenu>` support an element to put the menu into,
which is, the ancestor of the trigger buttun with `data-floating-menu-container` attribute.

This change also removes code for React15-, which we dropped the support from 9.x codebase.

Refs carbon-design-system/carbon#910.
Refs carbon-design-system/carbon#911.
asudoh added a commit to asudoh/carbon-components-react that referenced this issue Jun 28, 2018
This change makes `<FloatingMenu>` support an element to put the menu into,
which is, the ancestor of the trigger button with `data-floating-menu-container` attribute.

This change also removes code for React15-, which we dropped the support from 9.x codebase.

Refs carbon-design-system/carbon#910.
Refs carbon-design-system/carbon#911.
asudoh pushed a commit to asudoh/design-system-website that referenced this issue Jun 28, 2018
asudoh pushed a commit to asudoh/design-system-website that referenced this issue Jun 28, 2018
marijohannessen pushed a commit to carbon-design-system/carbon-components-react that referenced this issue Jun 29, 2018
This change makes `<FloatingMenu>` support an element to put the menu into,
which is, the ancestor of the trigger button with `data-floating-menu-container` attribute.

This change also removes code for React15-, which we dropped the support from 9.x codebase.

Refs carbon-design-system/carbon#910.
Refs carbon-design-system/carbon#911.
marijohannessen pushed a commit to carbon-design-system/design-system-website that referenced this issue Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants