This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
feat(FloatingMenu): support for specifying target container #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes `<FloatingMenu>` support an element to put the menu into, which is, the ancestor of the trigger button with `data-floating-menu-container` attribute. This change also removes code for React15-, which we dropped the support from 9.x codebase. Refs carbon-design-system/carbon#910. Refs carbon-design-system/carbon#911.
marijohannessen
approved these changes
Jun 29, 2018
|
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
<FloatingMenu>support an element to put the menu into,which is, the ancestor of the trigger button with
data-floating-menu-containerattribute.This change also removes code for React15-, which we dropped the support from 9.x codebase.
Refs carbon-design-system/carbon#910.
Refs carbon-design-system/carbon#911.
Changelog
New
<FloatingMenu>,target, which takes a function that returns the container the menu should be placed into<OverflowMenu>and<Tooltip>to pass along that new prop, both returning the ancestor of the trigger buttun withdata-floating-menu-containerattribute<input>in dev env, to trap keyboard focus. With it, tab navigation of overflow menu closes the menu once the focus goes out of the menuRemoved
<FloatingMenu>createPortal()(NowcreatePortal()runs with actual target of the floating menu)