Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Actionable/Persistent variant #8703

Closed
tay1orjones opened this issue May 17, 2021 · 2 comments · Fixed by #9494
Closed

[Notification] Actionable/Persistent variant #8703

tay1orjones opened this issue May 17, 2021 · 2 comments · Fixed by #9494
Labels
proposal: active development This request is actively being worked during the current sprint. role: dev 🤖 type: enhancement 💡

Comments

@tay1orjones
Copy link
Member

Summary

ToastNotification was updated as part of #8406 to use only an accessible role of alert, status, or log in v11. This change meant that Toast would no longer accept interactive elements/buttons/children. This leaves InlineNotification as the only notification component to allow action buttons.

This leaves a big gap for teams needing actionable notifications that mimic the visual styling of a Toast notification.

The proposal here is to add a new notification variant with the following requirements:

  • Mimics the visual styling of Toast
    • has constrained width
    • has box shadow
    • is not position: relative;
  • Action buttons are required, with potential visual design to indicate primary vs secondary actions
  • Always has role of alertdialog
  • Can optionally automatically take focus
  • Can optionally be closed via pressing esc
  • No timeout option
  • Proposed naming includes PersistentNotification, AlertDialogNotification, ActionableNotification

I originally intended to deliver this as part of #8560, but it was clear this needed visual/ux design.

@tay1orjones tay1orjones added type: enhancement 💡 role: visual 🎨 role: dev 🤖 proposal: active development This request is actively being worked during the current sprint. labels May 17, 2021
@tay1orjones tay1orjones changed the title [Notification] Actionable/Persistent variant [Notification] Actionable/Persistent variant exploration May 17, 2021
@tay1orjones tay1orjones added proposal: active development This request is actively being worked during the current sprint. and removed proposal: active development This request is actively being worked during the current sprint. labels May 17, 2021
@kingtraceyj
Copy link
Member

kingtraceyj commented Jun 8, 2021

For now, we are going to constrain the amount of action buttons in the new toast to only one action. We had a few iterations of what two action buttons would look like but after much discussion we believe it would be best to stick to one for the time being. We couldn't find that many use cases for two and the ones we did, the actions seemed redundant.

update! We are going with the small tertiary button.

Visual specs for toast with actions

Low contrast (uses light theme small tertiary button)
image

High contrast (uses dark theme small tertiary button)
image

@joshua-vaughn
Copy link

Cloud Pak for Data and the Cloud Pak Platform have already been including links in toast notifications as these are always accessible later from the Notification list page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal: active development This request is actively being worked during the current sprint. role: dev 🤖 type: enhancement 💡
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants