Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update toast pattern docs #2421

Merged
merged 12 commits into from
Feb 18, 2022
Merged

update toast pattern docs #2421

merged 12 commits into from
Feb 18, 2022

Conversation

kingtraceyj
Copy link
Member

@kingtraceyj kingtraceyj commented Jun 23, 2021 •
edited by tay1orjones
Loading

Closes #2402
Closes carbon-design-system/carbon#8761
Updating notification pattern with the toast types

Added:

  • Assertive
  • Polite

Updated:

  • Typo - switched horizontally to vertically
  • changed link to button

@kingtraceyj
update toast pattern
9f44ee8 
updating toast notification pattern docs to add in types of toasts
@vercel
Copy link

vercel bot commented Jun 23, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/4fzwnYaa8u8V3tteB3wB4QxKVuvJ
✅ Preview: https://carbondesignsystem-git-fork-kingtra-404521-carbon-design-system.vercel.app

@kingtraceyj
content and image update
935a4a7 
added polite and assertive dismissal actions, added polite and assertive image example
@kingtraceyj
Merge branch 'v11' into toast-pattern-v11
79f0e12
@kingtraceyj
updated copy, added image
a53910c 
updated punctuation and then added animated toasts images
@kingtraceyj
updated animation
3c89c52 
updated toast animation
@vercel
Copy link

vercel bot commented Jun 25, 2021

@kingtraceyj is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

@kingtraceyj kingtraceyj marked this pull request as ready for review June 25, 2021 15:09
@kingtraceyj kingtraceyj requested a review from a team June 25, 2021 15:09
@kingtraceyj kingtraceyj requested a review from a team as a code owner June 25, 2021 15:09
@alisonjoseph alisonjoseph removed their request for review June 25, 2021 15:10
@kingtraceyj kingtraceyj mentioned this pull request Jun 28, 2021
Closed
62 tasks
johnbister
johnbister approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@johnbister johnbister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@tay1orjones
Copy link
Member

@kingtraceyj If it's alright with you, I'm going to mark this as a draft for the moment. Once we have the "actionable" toast notification implemented via carbon-design-system/carbon#8703 we'll be able to frame the docs here more solidly around that final implementation

@tay1orjones tay1orjones marked this pull request as draft July 28, 2021 20:03
@tay1orjones tay1orjones mentioned this pull request Jul 28, 2021
Closed
3 tasks
@tay1orjones tay1orjones mentioned this pull request Oct 4, 2021
Closed
57 tasks
@kingtraceyj
updated text with actionable content
e4bf266 
• changed toast description within 'deciding what to use table'
• updated inline notification to include actionable
• updated toast notification with actionable guidelines
• took out assertive vs polite language
tay1orjones
tay1orjones approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for updating this

@kingtraceyj kingtraceyj marked this pull request as ready for review October 19, 2021 15:41
@kingtraceyj kingtraceyj requested a review from a team as a code owner October 19, 2021 15:41
@kingtraceyj kingtraceyj requested review from aagonzales and removed request for jeanservaas February 18, 2022 15:25
aagonzales
aagonzales approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kingtraceyj kingtraceyj merged commit 4d6679c into carbon-design-system:v11 Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbister johnbister johnbister approved these changes

@aagonzales aagonzales aagonzales approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kingtraceyj @tay1orjones @aagonzales @johnbister