Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using an action button in multi-line inline/toast notifications #7181

Closed
swwebster opened this issue Oct 29, 2020 · 3 comments
Closed
Labels
component: notification proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡

Comments

@swwebster
Copy link

swwebster commented Oct 29, 2020

Summary

Typically, when we use inline/toast notifications in our product, we are using multi-line notifications. (It's rare for our descriptions to be super brief, so we like the more optimal layout of the multi-line.) Along those same lines, usually our action description in the button is around 3 words long, which can take up quite a bit of horizontal space. If we could have action buttons in the multi-line notification as well as the single line, that would be great!

I believe this is a design and development change, since the multi-line component would need to support an action button.

image

Justification

Currently, our FEDs will be using a custom version of the component for more optimal layout. Going forward, it would be more optimal and efficient for our devs to be able to use a "approved" component

Desired UX and success metrics

Unfortunately, because of the complexity of our product, it's very rare that when we use an inline notification, that we have very brief descriptions. It's a constant negotiation with our Information/Content Developer to keep these descriptions short, but sometimes it simply needs to be a little longer. If the description is longer and has an action, then it doesn't look very good to use the single line notification with an action.

Here's a real world example I came across recently:
image

Context of the notification:
image

Having an action element in a multi-line notification is much better in this case.

Specific timeline issues / requests

For now, our devs are able to use the custom component I mentioned above, so it is not urgent. But it's definitely a nice to have!

NB: The Carbon team will try to work with your timeline, but it's not
guaranteed. The earlier you make a request in advance of a desired delivery
date, the better!

Available extra resources

I'm happy to help with building the component in Sketch if necessary. I'm sure my FED colleague could be consulted as well for the custom component that he created.

Carbon is a collaborative system. We encourage teams to build components and
submit them for integration as either add-ons or core components.

@andreancardona andreancardona added proposal: open This request has gone through triaging. We're determining whether we take this on or not. component: notification and removed status: needs triage 🕵️‍♀️ labels Oct 30, 2020
@vpicone
Copy link
Contributor

vpicone commented Jun 21, 2021

@tay1orjones is there an open issue for this, can we close it as duplicate?

@tay1orjones
Copy link
Member

@vpicone Yes, We've been tracking this as an exploration over in #8703. A finalized spec was recently posted and we'll be working from there.

Will close this one as a duplicate - thanks for opening the issue @swwebster! #8703 should meet your use case described here with some additional accessibility benefits.

@tay1orjones
Copy link
Member

Duplicate of #8703

@tay1orjones tay1orjones marked this as a duplicate of #8703 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: notification proposal: open This request has gone through triaging. We're determining whether we take this on or not. type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

4 participants