Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@carbon/icons replacing carbon-icons? #5551

Closed
1 of 2 tasks
davefp opened this issue Mar 5, 2020 · 2 comments · Fixed by #5574
Closed
1 of 2 tasks

@carbon/icons replacing carbon-icons? #5551

davefp opened this issue Mar 5, 2020 · 2 comments · Fixed by #5574
Labels
type: question ❓

Comments

@davefp
Copy link

davefp commented Mar 5, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Summary

The main carbon-components package lists carbon-icons as a dependency, but according to the answer given in #5542 this package is superseded by @carbon/icons.

My questions:

  1. Is there a workflow for using @carbon/icons with carbon-components? FWIW the icon docs still reference carbon-icons here: https://www.carbondesignsystem.com/guidelines/icons/usage/#svg-icons
  2. Are there plans on replacing the old icon dependency with the new one in carbon-components?

Relevant information

We're integrating the vanilla js/sass package with Ruby on Rails by referencing the svgs in the dist subfolder and inlining them using the inline_svg gem
@asudoh
Copy link
Contributor

asudoh commented Mar 6, 2020

Hi 👋 thank you for asking - carbon-icons hosts v9 icons, and @carbon/icons hosts v10 icons. Hope it clarifies.

@davefp
Copy link
Author

davefp commented Mar 7, 2020

I see. I've now integrated with@carbon/icons and it works for the most part. There seem to be a couple of buggy SVGs but I'll raise that separately.

One of my original questions is still outstanding though: Is there a roadmap for replacing carbon-icons with @carbon/icons as a dependency of the main carbon-components package?

asudoh added a commit to asudoh/carbon-components that referenced this issue Mar 9, 2020
@asudoh
fix(dependencies): update icons dependency in vanilla
788b2d9 
Also moves the icon library dependency from `dependencies` to
`peerDependencies` because icons in vanilla are something applications
put in their HTML, rather than what vanilla library directly uses.

Fixes carbon-design-system#5551.
@asudoh asudoh mentioned this issue Mar 9, 2020
Merged
asudoh added a commit that referenced this issue Mar 9, 2020
@asudoh
fix(dependencies): update icons dependency in vanilla (#5574)
e88e693 
Also moves the icon library dependency from `dependencies` to
`peerDependencies` because icons in vanilla are something applications
put in their HTML, rather than what vanilla library directly uses.

Fixes #5551.
joshblack pushed a commit to joshblack/carbon that referenced this issue Mar 10, 2020
@asudoh @joshblack
fix(dependencies): update icons dependency in vanilla (carbon-design-…
f793a15 
…system#5574)

Also moves the icon library dependency from `dependencies` to
`peerDependencies` because icons in vanilla are something applications
put in their HTML, rather than what vanilla library directly uses.

Fixes carbon-design-system#5551.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: question ❓
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(dependencies): update icons dependency in vanilla asudoh/carbon-components
2 participants
@davefp @asudoh