Skip to content

Commit

Permalink
fix(dependencies): update icons dependency in vanilla (#5574)
Browse files Browse the repository at this point in the history
Also moves the icon library dependency from `dependencies` to
`peerDependencies` because icons in vanilla are something applications
put in their HTML, rather than what vanilla library directly uses.

Fixes #5551.
  • Loading branch information
asudoh authored Mar 9, 2020
1 parent c23a07d commit e88e693
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/components/docs/experimental.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ For now, you can click the "expanded" viewing mode option and see the module
name available for each icon in the second-to-last column. So if you are looking
for the glyph version of an icon, you might see `/chevron--down` and in the far
right-hand side of the table (when in expanded mode) you'd see
`ChevronDownGlyph`. You can use this identifier alongside the `carbon-icons`
`ChevronDownGlyph`. You can use this identifier alongside the `carbon-icon`
helper by doing:

```hbs
Expand Down
4 changes: 3 additions & 1 deletion packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,13 @@
"freshy": ">= 1.0.3"
},
"dependencies": {
"carbon-icons": "^7.0.7",
"flatpickr": "4.6.1",
"lodash.debounce": "^4.0.8",
"warning": "^3.0.0"
},
"peerDependencies": {
"@carbon/icons": "^10.9.0"
},
"devDependencies": {
"@babel/core": "^7.0.0",
"@babel/plugin-proposal-class-properties": "^7.7.4",
Expand Down

0 comments on commit e88e693

Please sign in to comment.