Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statusIconDescription prop in React notification components should be optional #5527

Closed
asudoh opened this issue Mar 4, 2020 · 0 comments · Fixed by #5528
Closed

statusIconDescription prop in React notification components should be optional #5527

asudoh opened this issue Mar 4, 2020 · 0 comments · Fixed by #5528
Labels
type: bug 🐛

Comments

@asudoh
Copy link
Contributor

asudoh commented Mar 4, 2020

Given statucIconDescription in <InlineNotification> and one in <ToastNotification> have a fallback value, they shouldn't have isRequired in their prop types.
asudoh added a commit to asudoh/carbon-components that referenced this issue Mar 4, 2020
@asudoh
fix(InlineNotification): make statusIconDescription optional
4b2ce6e 
Given `statucIconDescription` in `<InlineNotification>` and one in
`<ToastNotification>` have a fallback value, they shouldn't have
`isRequired` in their prop types. This change fixes that.

Fixes carbon-design-system#5527.
@asudoh asudoh mentioned this issue Mar 4, 2020
Merged
asudoh added a commit that referenced this issue Mar 10, 2020
@asudoh
fix(InlineNotification): make statusIconDescription optional (#5528)
fde409c 
Given `statucIconDescription` in `<InlineNotification>` and one in
`<ToastNotification>` have a fallback value, they shouldn't have
`isRequired` in their prop types. This change fixes that.

Fixes #5527.
aledavila pushed a commit that referenced this issue Mar 18, 2020
@asudoh
fix(InlineNotification): make statusIconDescription optional (#5528)
952c780 
Given `statucIconDescription` in `<InlineNotification>` and one in
`<ToastNotification>` have a fallback value, they shouldn't have
`isRequired` in their prop types. This change fixes that.

Fixes #5527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(InlineNotification): make statusIconDescription optional asudoh/carbon-components
1 participant
@asudoh