fix(InlineNotification): make statusIconDescription optional (#5528)

Given `statucIconDescription` in `<InlineNotification>` and one in `<ToastNotification>` have a fallback value, they shouldn't have `isRequired` in their prop types. This change fixes that. Fixes #5527.
carbon-design-system · Mar 18, 2020 · 952c780 · 952c780
1 parent fc15616
commit 952c780
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap b/packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
@@ -3529,7 +3529,6 @@ Map {
         "type": "bool",
       },
       "iconDescription": Object {
-        "isRequired": true,
         "type": "string",
       },
       "kind": Object {
@@ -3558,7 +3557,6 @@ Map {
         "type": "string",
       },
       "statusIconDescription": Object {
-        "isRequired": true,
         "type": "string",
       },
       "subtitle": Object {
@@ -3595,7 +3593,6 @@ Map {
         "type": "bool",
       },
       "iconDescription": Object {
-        "isRequired": true,
         "type": "string",
       },
       "kind": Object {
@@ -3624,7 +3621,6 @@ Map {
         "type": "string",
       },
       "statusIconDescription": Object {
-        "isRequired": true,
         "type": "string",
       },
       "subtitle": Object {

diff --git a/packages/react/src/components/Notification/Notification.js b/packages/react/src/components/Notification/Notification.js
@@ -358,12 +358,12 @@ ToastNotification.propTypes = {
   /**
    * Provide a description for "close" icon that can be read by screen readers
    */
-  iconDescription: PropTypes.string.isRequired,
+  iconDescription: PropTypes.string,
 
   /**
    * Provide a description for "status" icon that can be read by screen readers
    */
-  statusIconDescription: PropTypes.string.isRequired,
+  statusIconDescription: PropTypes.string,
 
   /**
    * By default, this value is "toast". You can also provide an alternate type
@@ -504,12 +504,12 @@ InlineNotification.propTypes = {
   /**
    * Provide a description for "close" icon that can be read by screen readers
    */
-  iconDescription: PropTypes.string.isRequired,
+  iconDescription: PropTypes.string,
 
   /**
    * Provide a description for "status" icon that can be read by screen readers
    */
-  statusIconDescription: PropTypes.string.isRequired,
+  statusIconDescription: PropTypes.string,
 
   /**
    * By default, this value is "inline". You can also provide an alternate type