Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Needed to signify 'selected' item (current value) in List Box and other controls. #3988

Closed
chrisconnors-ibm opened this issue Sep 13, 2019 · 6 comments · Fixed by #4753

Comments

@chrisconnors-ibm
Copy link
Contributor

Summary

List box currently uses focus ring to indicate current value. need a design to indicate current value that doesn't collide with focus. see #3124 for context.

@laurenmrice
Copy link
Member

laurenmrice commented Sep 20, 2019

Design spec:

Hover state:
Add a 2px border on top of the hover that is the same color (hover-ui) so the border will appear in high contrast mode but visually blend in with the hover color in normal.

Selected state:
Add a checkmark icon inline with the selected row. The checkmark icon should be color icon-01. Make sure the selected row is color selected-ui. Ref open issue for dropdown enhancement: #3531

Artboard

@stale
Copy link

stale bot commented Oct 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Oct 20, 2019
@stale
Copy link

stale bot commented Oct 23, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Oct 23, 2019
@laurenmrice
Copy link
Member

NOT stale

@laurenmrice laurenmrice reopened this Oct 23, 2019
@stale stale bot removed status: inactive Will close if there's no further activity within a given time labels Oct 23, 2019
asudoh added a commit to asudoh/carbon-components that referenced this issue Nov 22, 2019
@stale
Copy link

stale bot commented Nov 22, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Nov 22, 2019
@laurenmrice laurenmrice removed the status: inactive Will close if there's no further activity within a given time label Nov 22, 2019
@asudoh
Copy link
Contributor

asudoh commented Nov 23, 2019

Refs #4374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants