Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Change default selection behavior #3531

Closed
laurenmrice opened this issue Jul 24, 2019 · 8 comments
Closed

[Dropdown] Change default selection behavior #3531

laurenmrice opened this issue Jul 24, 2019 · 8 comments

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jul 24, 2019

We need to change the default selection behavior of dropdown to include the current selection in place in the dropdown drawer with a checkmark inline.

Currently we do this two different ways. In Vanilla we take the option that is selected out of the dropdown drawer. In React we leave the option that is selected inside of the drawer with a selection state (the option that is selected does not move up to the top of the list, it stays in place inside the drawer.) It would be good to keep these consistent and include the checkmark in the drawer selection so it is more obvious and visible.

Ref conversation in #1936

Current:
Current default.png

New:
New default.png

@stale
Copy link

stale bot commented Aug 31, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 31, 2019
@stale
Copy link

stale bot commented Sep 3, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Sep 3, 2019
@laurenmrice
Copy link
Member Author

not stale this needs to be implemented

@laurenmrice laurenmrice reopened this Sep 16, 2019
@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Sep 16, 2019
@stale
Copy link

stale bot commented Oct 16, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Oct 16, 2019
@laurenmrice
Copy link
Member Author

not staleeeeeeeeee 😭

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Oct 16, 2019
@stale
Copy link

stale bot commented Nov 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Nov 20, 2019
@laurenmrice
Copy link
Member Author

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Nov 20, 2019
@asudoh
Copy link
Contributor

asudoh commented Feb 6, 2020

Same as #3988 and addressed by #4753.

@asudoh asudoh closed this as completed Feb 6, 2020
@joshblack joshblack mentioned this issue Feb 12, 2020
2 tasks
@joshblack joshblack mentioned this issue Mar 2, 2020
82 tasks
@joshblack joshblack mentioned this issue Mar 27, 2020
79 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants