Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVT 1 - React Header Base w/Navigation or the Header Base w/Navigation and Actions UI Shell has DAP violations #3572

Closed
snidersd opened this issue Jul 29, 2019 · 0 comments · Fixed by #4834
Closed

AVT 1 - React Header Base w/Navigation or the Header Base w/Navigation and Actions UI Shell has DAP violations #3572

snidersd opened this issue Jul 29, 2019 · 0 comments · Fixed by #4834
Labels
component: ui-shell type: a11y ♿

Comments

@snidersd
Copy link

Environment

macOS Mojave version 10.14.5
Chrome Version 75.0.3770.100 (Official Build) (64-bit)
Carbon v10 - React
DAP - July 2019 Ruleset

Detailed Description

Run DAP on the Header Base w/Navigation or the Header Base w/Navigation and Actions UI Shell. The following 5 violations are identified (see screenshot below):
HeaderNav

Note:

  1. The contrast issue relates to the Skip to Main link, which fails the WCAG Tests for G1: Adding a link at the top of each page that goes directly to the main content area
  2. Add a role to the parent of the menuitems. Use role="menu" or "menubar" or "group" to fix the issue. DAP only reports this issue if the page size reduced and the links do not display across the top of the page.
@aledavila aledavila added this to the UI Shell - A11y Project Team milestone Sep 30, 2019
@dakahn dakahn modified the milestones: UI Shell - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@dakahn dakahn mentioned this issue Nov 22, 2019
Closed
asudoh added a commit to asudoh/carbon-components that referenced this issue Dec 9, 2019
@asudoh
feat(ui-shell): switch header nav role for side nav
f591d1a 
This change allows users of `<HeaderMenu>` and `<HeaderMenuItem>` to
specify their ARIA roles so the a11y structure won't be broken when
they are put in side nav for narrow screen.

Fixes carbon-design-system#3572.
@asudoh asudoh mentioned this issue Dec 9, 2019
Merged
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
@abbeyhrt abbeyhrt mentioned this issue Jan 6, 2020
Closed
2 tasks
tw15egan added a commit that referenced this issue Jan 15, 2020
@asudoh @joshblack
@tw15egan @emyarod
fix(ui-shell): remove role="menuitem" from header links
d9935c3 
* feat(ui-shell): switch header nav role for side nav

This change allows users of `<HeaderMenu>` and `<HeaderMenuItem>` to
specify their ARIA roles so the a11y structure won't be broken when
they are put in side nav for narrow screen.

Fixes #3572.

* fix(ui-shell): remove role in a tag

* chore(UIShell): update snapshot

* fix(HeaderMenuItem): style fix

* Update packages/components/src/components/ui-shell/_side-nav.scss

Co-Authored-By: emyarod <[email protected]>

* Update packages/components/src/components/ui-shell/_side-nav.scss

Co-Authored-By: emyarod <[email protected]>

* fix(HeaderMenu): more style fix

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: emyarod <[email protected]>
joshblack added a commit to joshblack/carbon that referenced this issue Jan 23, 2020
@asudoh @joshblack
@tw15egan @emyarod
fix(ui-shell): remove role="menuitem" from header links
63c950e 
* feat(ui-shell): switch header nav role for side nav

This change allows users of `<HeaderMenu>` and `<HeaderMenuItem>` to
specify their ARIA roles so the a11y structure won't be broken when
they are put in side nav for narrow screen.

Fixes carbon-design-system#3572.

* fix(ui-shell): remove role in a tag

* chore(UIShell): update snapshot

* fix(HeaderMenuItem): style fix

* Update packages/components/src/components/ui-shell/_side-nav.scss

Co-Authored-By: emyarod <[email protected]>

* Update packages/components/src/components/ui-shell/_side-nav.scss

Co-Authored-By: emyarod <[email protected]>

* fix(HeaderMenu): more style fix

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: TJ Egan <[email protected]>
Co-authored-by: emyarod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ui-shell type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui-shell): switch header nav role for side nav asudoh/carbon-components
5 participants
@mattrosno @joshblack @aledavila @snidersd @dakahn