Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UI Shell in Accordance with W3C Authoring Practices Guidelines #4766

Closed
dakahn opened this issue Nov 22, 2019 · 0 comments
Closed
Labels
severity: 1 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@dakahn
Copy link
Contributor

dakahn commented Nov 22, 2019

closes #3572
closes #3576
closes #3590
closes #3661
closes #3591
closes #3584
closes #3583
closes #3578
closes #3580

UI Shell has serious accessibility issues necessitating a larger refactor effort getting it more in line with the Authoring Practices menu navigation example, and the their Menu Button example,

That said I do not think we should implement a role="menu" style keyboard navigation pattern (which is counter to some of the APG's guidance) and instead keep our simpler tab based implementation (ref: Heydon Pickering, Adrian Roselli)

It'd be cool if we could take this opportunity to implement React Hooks based updates (as seen in @vpicone work on our website). We should also consider UI Shell's functionality and usability when it comes to mobile since that's a focus moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 1 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Development

No branches or pull requests

2 participants