Data table: v11 audit

[aagonzales]

Audit

A designer and developer will pair on this audit, some tasks may be discipline focused. Follow the checklist below for the features and items to review. If there are no issues with the item then check the item as complete. If any problems or bugs come up when auditing add a comment to this issue with the problem and how to correct it (if you know how). Bugs do not need to be fixed while auditing.

Resources

• Design spec in Sketch
• V11 Website
• SCSS
• Storybook

Checklist

Visual (in React code)
Design and dev check

• Component is using the correct design tokens (color and type), see design spec and scss code.
• Component is rendering correctly across themes and layers, see design spec and storybook.
  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme
• Component is rendering correctly across browsers (check themes across browsers as well), see storybook.
  • Firefox
  • Safari
  • Chrome
• Component sizes are rendering and named correctly (if applicable)

Website (v11)
Design checks

• Style tab has correct design tokens listed
• Style and usage tabs are using the correct size props names (if applicable)
• Usage tab is up-to-date for with any v11 behavioral changes (if any)
• Live Demo has applied v11 changes
  • Themes are rendering correctly
  • Size props are named correctly
  • No light props included

Design Kits (Sketch only)
Design checks

• Correct design tokens (type and color) are used
• Component using the correct size prop names
• Any additional v11 behaviors have been added

Storybook
Dev checks

• Confirm that prop table is populating
• Take note of missing examples/stories (if any)

React package
Dev checks

• Go to https://codesandbox.io/s/github/carbon-design-system/carbon/tree/main/packages/react/examples/codesandbox and confirm that you can use the component as expected from @carbon/react

Accessibility
Dev checks

• Confirm that there are no violations in Accessibility checker
• Confirm that component works as expected with VoiceOver

Migration docs
Design and dev check

• Any breaking changes to this component are present in the v11 migration guide.
  • Design
  • Develop

[aagonzales]

Visual

Toolbar

• .#{$prefix}--toolbar-search-container-expandable.#{$prefix}--search--disabled .#{$prefix}--search-magnifier-icon background color should be just $layer
• The hover on the settings overflow menu is not showing up correctly. Should be using $layer-hover not $background-hover

• .#{$prefix}--batch-summary__para update typestyle to $body-compact-01

Core table

• .#{$prefix}--data-table-header__title update type style to $heading-03
• .#{$prefix}--data-table-header__description update type style toe $body-compact-01
• // Radio border-bottom should be $border-subtle-selected not $layer-active
• // First row tr.#{$prefix}--data-table--selected:first-of-type td border color should be $border-subtle-selected

Expandable table

• .#{$prefix}--table-expand__svg should be $icon-primary not v10 $ui-05
• borders and box-shadows using $layer-active is incorrect and should be using $border-subtle-selected instead.

[aagonzales]

Storybook

• In the "Batch action / Sm" story the table rows should be changing size along with the action bar.

[aagonzales]

Website

• Data table (sorting): incorrect link to storybook on usage page carbon-website#2721
• [data table] update focus size in images carbon-website#2301

Live demo

• Sizes are named incorrectly
• Some theme bugs in the dark theme with hover colors (only in demo not in component code)

[aagonzales]

Kit

• Update select-borders from layer-active-01 to border-subtle-selected-01
  • W
  • G10
  • G90
  • G100
• Update column header to use layer-accent-01
  • W
  • G10
  • G90
  • G100
• Updated column header hover to use layer-accent-hover-01
  • W
  • G10
  • G90
  • G100

[tay1orjones]

Closing as this is primarily complete. We've got a few bugs outlined to continue on from here, #10747, #11138, #10889