Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: DataTable overflowMenuOnHover is broken #10747

Closed
2 tasks done
alexandertrefz opened this issue Feb 14, 2022 · 0 comments · Fixed by #11247
Closed
2 tasks done

[Bug]: DataTable overflowMenuOnHover is broken #10747

alexandertrefz opened this issue Feb 14, 2022 · 0 comments · Fixed by #11247
Assignees
@aledavila
Labels
component: data-table package: @carbon/react @carbon/react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Milestone
2022 Q2

Comments

@alexandertrefz
Copy link

Package

@carbon/react

Browser

Chrome, Safari, Firefox, Edge

Package version

v0.13.0

React version

v17.0.2

Description

###Expected

DataTable sets overflowMenuOnHover to true by default. This should hide OverflowMenus in DataTableRows.

Actual

OverflowMenus are never hidden.

Reason

Documentation is rather poor on this behaviour, but digging through the commit history turned up this commit. Even when .cds--table-column-menu is set on the correct TableCell, the OverflowMenu within it never disappears, because the SVG inside the Button that triggers the Menu is lacking the .cds--overflow-menu__icon class.

CodeSandbox example

https://carbon-react-next.netlify.app/?path=/story/components-datatable-toolbar--with-overflow-menu

Steps to reproduce

Go to https://carbon-react-next.netlify.app/?path=/story/components-datatable-toolbar--with-overflow-menu and note that the overflow menu is always visible, not just on hover.

Code of Conduct
@jnm2377 jnm2377 moved this to 🕵️‍♀️ Triage in Design System Feb 16, 2022
@tay1orjones tay1orjones added this to the v11 GA milestone Feb 25, 2022
@tay1orjones tay1orjones moved this from 🕵️‍♀️ Triage to ⏱ Backlog in Design System Feb 28, 2022
@tay1orjones tay1orjones mentioned this issue Apr 11, 2022
Closed
25 tasks
@aledavila aledavila moved this from ⏱ Backlog to 🏗 In Progress in Design System Apr 19, 2022
@aledavila aledavila mentioned this issue Apr 19, 2022
Merged
@tay1orjones tay1orjones modified the milestones: v11 GA , 2022 Q2 Apr 21, 2022
@kodiakhq kodiakhq bot closed this as completed in #11247 Apr 22, 2022
Repository owner moved this from 🏗 In Progress to ✅ Done in Design System Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aledavila aledavila

Labels
component: data-table package: @carbon/react @carbon/react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Design System
Archived in project
Milestone
2022 Q2
Development

Successfully merging a pull request may close this issue.

chore(data-table): update overflow menu storybook
4 participants
@alexandertrefz @tay1orjones @aledavila @jnm2377