Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: DataTable overflowMenuOnHover is broken #10747

Closed
2 tasks done
alexandertrefz opened this issue Feb 14, 2022 · 0 comments · Fixed by #11247
Closed
2 tasks done

[Bug]: DataTable overflowMenuOnHover is broken #10747

alexandertrefz opened this issue Feb 14, 2022 · 0 comments · Fixed by #11247
Assignees
Milestone

Comments

@alexandertrefz
Copy link

Package

@carbon/react

Browser

Chrome, Safari, Firefox, Edge

Package version

v0.13.0

React version

v17.0.2

Description

###Expected

DataTable sets overflowMenuOnHover to true by default. This should hide OverflowMenus in DataTableRows.

Actual

OverflowMenus are never hidden.

Reason

Documentation is rather poor on this behaviour, but digging through the commit history turned up this commit. Even when .cds--table-column-menu is set on the correct TableCell, the OverflowMenu within it never disappears, because the SVG inside the Button that triggers the Menu is lacking the .cds--overflow-menu__icon class.

CodeSandbox example

https://carbon-react-next.netlify.app/?path=/story/components-datatable-toolbar--with-overflow-menu

Steps to reproduce

Go to https://carbon-react-next.netlify.app/?path=/story/components-datatable-toolbar--with-overflow-menu and note that the overflow menu is always visible, not just on hover.

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants