Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: audit fixes 1 #2752

Merged
merged 3 commits into from
Feb 28, 2022
Merged

docs: audit fixes 1 #2752

merged 3 commits into from
Feb 28, 2022

Conversation

aagonzales
Copy link
Member

@aagonzales aagonzales commented Feb 25, 2022

Closes

Related audit issues

Updates

Accordion

  • Color/interactive: disabled border = $border-subtle
  • Color/interactive: image needs to say the states
  • Updated docs to include left icon alignment as a do.

Button

  • Color/Secondary: remove container border row
  • Color/Tertiary: update label-hover = $text-inverse
  • Color/Tertiary: updated icon-hover = $icon-inverse
  • Color/Tertiary: add label-active = $text-inverse
  • Color/Tertiary: add icon-active = $icon-inverse
  • Color/Tertiary: update label-disabled = $text-disabled
  • Color/Tertiary: update icon-disabled = $icon-disabled
  • Color/Ghost (icon only): Update all v10 token names to v11 token names
  • Color/Danger-secondary: label-disabled = $text-disabled
  • Color/Danger-secondary: icon-disabled = $icon-disabled
  • Color/Danger-ghost: label-disabled = $text-disabled
  • Color/Danger-ghost: icon-disabled = $icon-disabled
  • Updated image for ghost button spec

Content switcher

  • Style tab - Color: update unselect background = transparent
  • Style tab - Color: add border = $border-inverse
  • Style tab - Color: add focus-inset

Data table

  • Usage / Behaviors - update the focus targets in the image
  • On usage tab, updated link to sort example in the storybook

@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/carbondesignsystem/BvTLEiTP4aVhN8K5rC6YYd5MQk63
✅ Preview: https://carbondesignsystem-git-fork-aagonza-2a3495-carbon-design-system.vercel.app

@laurenmrice
Copy link
Member

  • Looks great! The only thing I see missing is a row for $focus-inset for the Content switcher component on the Style tab.

@aagonzales
Copy link
Member Author

oops forgot to hit save on that change. Should be fixed now @laurenmrice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants