Skip to content

Commit

Permalink
fix(InlineNotification): make statusIconDescription optional
Browse files Browse the repository at this point in the history
Given `statucIconDescription` in `<InlineNotification>` and one in
`<ToastNotification>` have a fallback value, they shouldn't have
`isRequired` in their prop types. This change fixes that.

Fixes #5527.
  • Loading branch information
asudoh committed Mar 4, 2020
1 parent 68fb8ef commit 4b2ce6e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/react/src/components/Notification/Notification.js
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ ToastNotification.propTypes = {
/**
* Provide a description for "status" icon that can be read by screen readers
*/
statusIconDescription: PropTypes.string.isRequired,
statusIconDescription: PropTypes.string,

/**
* By default, this value is "toast". You can also provide an alternate type
Expand Down Expand Up @@ -509,7 +509,7 @@ InlineNotification.propTypes = {
/**
* Provide a description for "status" icon that can be read by screen readers
*/
statusIconDescription: PropTypes.string.isRequired,
statusIconDescription: PropTypes.string,

/**
* By default, this value is "inline". You can also provide an alternate type
Expand Down

0 comments on commit 4b2ce6e

Please sign in to comment.