Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

feat(input): implement password input #947

Merged
merged 9 commits into from
Feb 22, 2022
Merged

feat(input): implement password input #947

merged 9 commits into from
Feb 22, 2022

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 8, 2022

Related Ticket(s)

#305
#942
carbon-design-system/carbon-for-ibm-dotcom#9769

Description

This PR updates the input component so that input type="password" together with the show-password-visibility-toggle being set to true will enable the Carbon password input styles

Confirm that the password input appears and functions as expected (Note that the tooltip on hover and focus of the password visibility toggle button is blocked by carbon-design-system/carbon-for-ibm-dotcom#9770)

image

image

image

image

Changelog

New

  • show-password-visibility-toggle prop

Changed

  • default input field size (md instead of lg now)

@emyarod emyarod force-pushed the 305-feat/password-input branch from 052758a to c774f07 Compare February 8, 2022 21:33
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/947/index.html

Built with commit: 49793698f08d16c615a521f31bff7a49cb216418

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/947/index.html

Built with commit: 49793698f08d16c615a521f31bff7a49cb216418

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/947/index.html

Built with commit: 49793698f08d16c615a521f31bff7a49cb216418

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 8, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/947/index.html

Built with commit: 49793698f08d16c615a521f31bff7a49cb216418

@emyarod emyarod marked this pull request as ready for review February 9, 2022 20:38
@emyarod emyarod requested a review from a team as a code owner February 9, 2022 20:38
@emyarod emyarod force-pushed the 305-feat/password-input branch 2 times, most recently from 88ea3ef to 46de57d Compare February 21, 2022 16:52
@emyarod emyarod force-pushed the 305-feat/password-input branch from 6fba973 to 4db8efa Compare February 21, 2022 19:30
RichKummer
RichKummer approved these changes Feb 22, 2022
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @emyarod!

kennylam
kennylam approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emyarod!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 22, 2022
@RichKummer RichKummer mentioned this pull request Feb 22, 2022
Closed
@kodiakhq kodiakhq bot merged commit 1d74a21 into carbon-design-system:main Feb 22, 2022
@emyarod emyarod deleted the 305-feat/password-input branch March 1, 2022 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@kennylam kennylam kennylam approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emyarod @ibmdotcom-bot @kennylam @RichKummer @ariellalgilmore