Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

docs(input): fix input type knob #942

Merged
merged 2 commits into from
Feb 7, 2022
Merged

docs(input): fix input type knob #942

merged 2 commits into from
Feb 7, 2022

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Feb 4, 2022 •
edited
Loading

Related Ticket(s)

#87

Description

This PR updates the input type knob generator so that it works properly. Changing the input type prop should now change the rendered input type as expected

@emyarod emyarod requested a review from a team as a code owner February 4, 2022 19:22
@emyarod emyarod self-assigned this Feb 4, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 4, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Vue:
https://carbon-web-components-vue.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/942/index.html

Built with commit: 0afb6cfc1168de039ebb01d179c861259091aa27

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 4, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/942/index.html

Built with commit: 0afb6cfc1168de039ebb01d179c861259091aa27

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 4, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - React:
https://carbon-web-components-react.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/942/index.html

Built with commit: 0afb6cfc1168de039ebb01d179c861259091aa27

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 4, 2022 •
edited
Loading

Deploy preview created for Carbon Web Components - Angular:
https://carbon-web-components-angular.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/942/index.html

Built with commit: 0afb6cfc1168de039ebb01d179c861259091aa27

jeffchew
jeffchew approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Feb 7, 2022
@kodiakhq kodiakhq bot merged commit 617afa4 into carbon-design-system:main Feb 7, 2022
@emyarod emyarod deleted the docs/fix-input-type-knob branch February 8, 2022 15:58
@emyarod emyarod mentioned this pull request Feb 8, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees

@emyarod emyarod

Labels
Ready to merge Label for the pull requests that are ready to merge storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyarod @ibmdotcom-bot @jeffchew