Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): add missing styles for breadcrumb and modal #9942

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix(styles): add missing styles for breadcrumb and modal #9942

merged 1 commit into from
Jan 25, 2023

Conversation

annawen1
Copy link
Member

Related Ticket(s)

[breadcrumb]: / separator not showing on v1.27.0 #9936
Modal not displaying with @carbon/web-components 1.23.0 #9923

Description

Some styles have not been extending from carbon-components for bx-modal and bx-breadcrumb components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours.

Changelog

Changed

  • added styles from carbon-components that are not showing for bx-modal and bx-breadcrumb

@annawen1 annawen1 requested a review from a team as a code owner January 25, 2023 17:09
@annawen1 annawen1 changed the base branch from main to release/v1.43.0 January 25, 2023 17:09
ariellalgilmore
ariellalgilmore approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Carbon Web Components":
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9942/index.html

Built with commit: d155e4cca8a388fad0eb19b1f1529f2c783f24fe

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9942/index.html

Built with commit: d155e4cca8a388fad0eb19b1f1529f2c783f24fe

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9942/index.html

Built with commit: d155e4cca8a388fad0eb19b1f1529f2c783f24fe

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9942/index.html

Built with commit: d155e4cca8a388fad0eb19b1f1529f2c783f24fe

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9942/index.html

Built with commit: d155e4cca8a388fad0eb19b1f1529f2c783f24fe

@annawen1 annawen1 added Ready to merge Label for the pull requests that are ready to merge labels Jan 25, 2023
@kodiakhq kodiakhq bot merged commit 9a90ea1 into carbon-design-system:release/v1.43.0 Jan 25, 2023
@annawen1 annawen1 deleted the fix/modal-breadcrumb-style branch January 25, 2023 19:50
m4olivei added a commit to andy-blum/carbon-for-ibm-dotcom that referenced this pull request Feb 6, 2023
@m4olivei
Merge branch 'main' into fix/lightbox-carousel-QA
f2deb96 
* main:
  chore(platform): add indexing file for `carbon-web-components` (carbon-design-system#9960)
  fix(tabs-extended-media): safari hover (carbon-design-system#9974)
  chore(release): publish
  chore(release): publish
  chore(changelog): incorporate cwc into change log task (carbon-design-system#9975)
  fix(styles): downgrade sass version as there is an issue with @extend (carbon-design-system#9973)
  fix(issue-template): add cwc option (carbon-design-system#9967)
  chore(cwc): generate cwc internal vendor package (carbon-design-system#9953)
  chore(deps): bump ua-parser-js from 0.7.32 to 0.7.33 (carbon-design-system#9952)
  chore(deps): bump actions/setup-node from 2 to 3 (carbon-design-system#9943)
  chore(deps): bump peter-evans/repository-dispatch from 1 to 2 (carbon-design-system#9945)
  chore(deps): bump github/codeql-action from 1 to 2 (carbon-design-system#9944)
  chore(deps): bump actions/checkout from 2 to 3 (carbon-design-system#9946)
  chore(deps): bump act10ns/slack from 1 to 2 (carbon-design-system#9947)
  chore(release): publish
  fix(styles): add missing styles for breadcrumb and modal (carbon-design-system#9942)
  Create dependabot.yml
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 8, 2023
@annawen1 @kennylam
fix(styles): add missing styles for breadcrumb and modal (carbon-desi…
261b730 
…gn-system#9942)

### Related Ticket(s)

[breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936
Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923

### Description

Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours.

### Changelog

**Changed**

- added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@annawen1
fix(styles): add missing styles for breadcrumb and modal (carbon-desi…
ee57e6b 
…gn-system#9942)

### Related Ticket(s)

[breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936
Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923

### Description

Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours.

### Changelog

**Changed**

- added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@annawen1
fix(styles): add missing styles for breadcrumb and modal (carbon-desi…
82f1522 
…gn-system#9942)

### Related Ticket(s)

[breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936
Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923

### Description

Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours.

### Changelog

**Changed**

- added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annawen1 @ibmdotcom-bot @ariellalgilmore