-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal not displaying with @carbon/web-components 1.23.0 #9923
Comments
kennylam
assigned annawen1 and unassigned jeffchew, RichKummer, ljcarot, IgnacioBecerra and oliviaflory
Jan 23, 2023
kodiakhq bot
pushed a commit
that referenced
this issue
Jan 25, 2023
### Related Ticket(s) [breadcrumb]: / separator not showing on v1.27.0 #9936 Modal not displaying with @carbon/web-components 1.23.0 #9923 ### Description Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours. ### Changelog **Changed** - added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Mar 8, 2023
…gn-system#9942) ### Related Ticket(s) [breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936 Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923 ### Description Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours. ### Changelog **Changed** - added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Dec 4, 2023
…gn-system#9942) ### Related Ticket(s) [breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936 Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923 ### Description Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours. ### Changelog **Changed** - added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this issue
Jun 11, 2024
…gn-system#9942) ### Related Ticket(s) [breadcrumb]: / separator not showing on v1.27.0 carbon-design-system#9936 Modal not displaying with @carbon/web-components 1.23.0 carbon-design-system#9923 ### Description Some styles have not been extending from `carbon-components` for `bx-modal` and `bx-breadcrumb` components. Will need to dig further to see why they aren't showing, but in the mean time we can add those styles to ours. ### Changelog **Changed** - added styles from `carbon-components` that are not showing for `bx-modal` and `bx-breadcrumb` <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Today I noticed the change of package from carbon-web-components to @carbon/web-components.
(I am not sure this is the correct issue page: is not updated for package @carbon/web-components)
I have applied the change in my project's package.json. This is what I found:
I've seen that style.visibility is hidden for "open = true" property.
Thank you
Component(s) impacted
Modal web component
Browser
Chrome, Firefox
Carbon for IBM.com version
1.23.0
Severity
Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.
Application/website
Internal website
Package
@carbon/ibmdotcom-web-components
CodeSandbox example
Including the storybook sample re-creates the issue
Steps to reproduce the issue (if applicable)
Put a button in a page and open the modal that the example shows. (Vue example):
Release date (if applicable)
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: