Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): update logo url protocol #9914

Merged
merged 2 commits into from
Jan 17, 2023
Merged

fix(masthead): update logo url protocol #9914

merged 2 commits into from
Jan 17, 2023

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#9567

Description

This updates the React masthead logo URL to use https.

Changelog

Changed

  • React masthead logo URL changed to use https

@kennylam kennylam added the package: react Work necessary for the Carbon for IBM.com react components package label Jan 17, 2023
@kennylam kennylam requested a review from a team as a code owner January 17, 2023 20:23
emyarod
emyarod approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9914/index.html

Built with commit: bd6ff69c2c4a5ef57aa787aeffe59b0cfcc186d0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9914/index.html

Built with commit: bd6ff69c2c4a5ef57aa787aeffe59b0cfcc186d0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9914/index.html

Built with commit: bd6ff69c2c4a5ef57aa787aeffe59b0cfcc186d0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9914/index.html

Built with commit: bd6ff69c2c4a5ef57aa787aeffe59b0cfcc186d0

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 17, 2023
@kodiakhq kodiakhq bot merged commit ece8c04 into carbon-design-system:main Jan 17, 2023
@kennylam kennylam deleted the fix/masthead-logo-https-9567 branch January 17, 2023 23:40
m4olivei added a commit to andy-blum/carbon-for-ibm-dotcom that referenced this pull request Jan 19, 2023
@m4olivei
Merge branch 'main' into fix/lightbox-carousel-QA
c17c693 
* main:
  chore(settings): update settings to v1.43.0
  chore(files): remove unused log file (carbon-design-system#9913)
  fix(masthead): update logo url protocol (carbon-design-system#9914)
  chore(release): publish
  feat(tile): add custom event to `selected-tile` (carbon-design-system#9898)
  fix(deps): update dependency isomorphic-dompurify to v0.26.0 (carbon-design-system#9906)
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@kennylam
fix(masthead): update logo url protocol (carbon-design-system#9914)
e9d54e0 
### Related Ticket(s)

carbon-design-system#9567 

### Description

This updates the React masthead logo URL to use `https`.

### Changelog

**Changed**

- React masthead logo URL changed to use `https`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@kennylam
fix(masthead): update logo url protocol (carbon-design-system#9914)
885435e 
### Related Ticket(s)

carbon-design-system#9567 

### Description

This updates the React masthead logo URL to use `https`.

### Changelog

**Changed**

- React masthead logo URL changed to use `https`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@emyarod emyarod emyarod approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennylam @ibmdotcom-bot @emyarod @annawen1