Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tile): add custom event to selected-tile #9898

Merged
merged 2 commits into from
Jan 17, 2023
Merged

feat(tile): add custom event to selected-tile #9898

merged 2 commits into from
Jan 17, 2023

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#9740

Description

Adds custom event after selectable-tile is selected

Changelog

New

  • bx-selectable-tile-changed custom event added to selectable-tile

@kennylam kennylam requested a review from a team as a code owner January 10, 2023 17:50
@kennylam kennylam changed the title feat(tile): add selected event to selected-tile feat(tile): add custom event to selected-tile Jan 10, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 10, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9898/index.html

Built with commit: 74d08e7c4b9c1a499b97ace3de453f75ec795c38

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 10, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9898/index.html

Built with commit: 74d08e7c4b9c1a499b97ace3de453f75ec795c38

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 10, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9898/index.html

Built with commit: 74d08e7c4b9c1a499b97ace3de453f75ec795c38

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 10, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9898/index.html

Built with commit: 74d08e7c4b9c1a499b97ace3de453f75ec795c38

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 10, 2023 •
edited
Loading

Deploy preview created for package "Carbon Web Components":
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9898/index.html

Built with commit: 74d08e7c4b9c1a499b97ace3de453f75ec795c38

emyarod
emyarod approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 17, 2023
@kodiakhq kodiakhq bot merged commit 11fe5bf into carbon-design-system:main Jan 17, 2023
@kennylam kennylam deleted the feat/selectable-tile-add-event-9740 branch January 17, 2023 17:33
m4olivei added a commit to andy-blum/carbon-for-ibm-dotcom that referenced this pull request Jan 19, 2023
@m4olivei
Merge branch 'main' into fix/lightbox-carousel-QA
c17c693 
* main:
  chore(settings): update settings to v1.43.0
  chore(files): remove unused log file (carbon-design-system#9913)
  fix(masthead): update logo url protocol (carbon-design-system#9914)
  chore(release): publish
  feat(tile): add custom event to `selected-tile` (carbon-design-system#9898)
  fix(deps): update dependency isomorphic-dompurify to v0.26.0 (carbon-design-system#9906)
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@kennylam
feat(tile): add custom event to selected-tile (carbon-design-system…
08e14b1 
…#9898)

### Related Ticket(s)

carbon-design-system#9740 

### Description

Adds custom event after `selectable-tile` is selected

### Changelog

**New**

- `bx-selectable-tile-changed` custom event added to `selectable-tile`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@kennylam
feat(tile): add custom event to selected-tile (carbon-design-system…
16adc45 
…#9898)

### Related Ticket(s)

carbon-design-system#9740 

### Description

Adds custom event after `selectable-tile` is selected

### Changelog

**New**

- `bx-selectable-tile-changed` custom event added to `selectable-tile`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @emyarod