Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carousel): apply same height function to heading used in dds-card-cta #8336

Merged
merged 15 commits into from
Mar 3, 2022

Conversation

proeung
Copy link
Contributor

@proeung proeung commented Feb 18, 2022

Related Ticket(s)

#8247

Description

  • This PR addresses the alignment issue seen when there's a mixture of <dds-card> and <dds-card-cta> within the <dds-carousel> component.

Changelog

New

Removed

  • Removed <dds-card-heading> from CardsWithVideos as the card heading should be coming from the Mediacenter/Kaltura because this is the content usage when displaying a card with a video button.

@proeung proeung added adopter: AEM used when component or pattern will be used by this adopter package: web components Work necessary for the IBM.com Library web components package labels Feb 18, 2022
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 18, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 18, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 18, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 18, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 18, 2022

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 19, 2022

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8336/index.html

Built with commit: bb7e3a760e8437d6dc5b99cdadcb729ae35c8dfc

@proeung proeung marked this pull request as ready for review February 21, 2022 16:12
@proeung proeung requested a review from a team as a code owner February 21, 2022 16:12
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 21, 2022

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/8336/index.html

Built with commit: bb7e3a760e8437d6dc5b99cdadcb729ae35c8dfc

@IgnacioBecerra
Copy link
Contributor

@proeung Looking good upon resize, but at first render it looks a bit off:

Screen Shot 2022-02-21 at 12 39 43 PM

This probably happens due to the max height being applied from the other regular cards before the tallest title (from the video API) comes through. Maybe we could add setTimeout or something that will trigger once the video titles come through that will retrigger the sameHeight function.

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @proeung!

@proeung proeung added Ready to merge Label for the pull requests that are ready to merge and removed 👀 eyes needed labels Mar 2, 2022
@kodiakhq kodiakhq bot merged commit a7f11f6 into carbon-design-system:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Carousel]: mixture of dds-card and dds-card-cta causing heading alignment issue - DPO Consulting
5 participants