-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(carousel): apply same height function to heading used in dds-card-cta #8336
fix(carousel): apply same height function to heading used in dds-card-cta #8336
Conversation
…-dotcom into fix/carousel-8247
Deploy preview created for package Built with commit: 905be0f6482b3c9e6efad195f35b32f79e5402df |
Deploy preview created for package Built with commit: 905be0f6482b3c9e6efad195f35b32f79e5402df |
Deploy preview created for package Built with commit: 905be0f6482b3c9e6efad195f35b32f79e5402df |
Deploy preview created for package Built with commit: 905be0f6482b3c9e6efad195f35b32f79e5402df |
Deploy preview created for package Built with commit: 54c87cdc4de081a5b3dade2dfa187f8470ee7895 |
Deploy preview created for package Built with commit: bb7e3a760e8437d6dc5b99cdadcb729ae35c8dfc |
Deploy preview created for package Built with commit: bb7e3a760e8437d6dc5b99cdadcb729ae35c8dfc |
@proeung Looking good upon resize, but at first render it looks a bit off: This probably happens due to the max height being applied from the other regular cards before the tallest title (from the video API) comes through. Maybe we could add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @proeung!
Related Ticket(s)
#8247
Description
<dds-card>
and<dds-card-cta>
within the<dds-carousel>
component.Changelog
New
Removed
<dds-card-heading>
fromCardsWithVideos
as the card heading should be coming from the Mediacenter/Kaltura because this is the content usage when displaying a card with a video button.