Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cta-section): ensure buttons are not allowed as cta types #7782

Merged
merged 4 commits into from
Dec 3, 2021
Merged

fix(cta-section): ensure buttons are not allowed as cta types #7782

merged 4 commits into from
Dec 3, 2021

Conversation

IgnacioBecerra
Copy link
Contributor

Related Ticket(s)

#7439

Description

Currently the CTA Section story allowed Buttons as CTA types for the content items. With this new PR, I removed the ability to choose Buttons from the knob, as well as ensure that any slotted Button Group does not render if within a cta-block-item element.

Changelog

New

  • ButtonGroup will not rendered if used inside a cta-block-item element

Removed

  • buttons option in CTA type knob for CTASection

@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner November 30, 2021 20:53
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 30, 2021 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 30, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 30, 2021 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 30, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 30, 2021 •
edited
Loading

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 1, 2021 •
edited
Loading

Deploy preview created for package "React (Codesandbox Examples)":
https://react-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 1, 2021 •
edited
Loading

Deploy preview created for package "Web Components (Codesandbox Examples)":
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7782/index.html

Built with commit: 894b875505e9f75b7069e29de5c1425163af8da7

emyarod
emyarod reviewed Dec 1, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just one question about the filtering logic!

packages/web-components/src/components/cta-block/cta-block-item.ts Outdated Show resolved Hide resolved
@emyarod emyarod mentioned this pull request Dec 1, 2021
Closed
ariellalgilmore
ariellalgilmore approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IgnacioBecerra IgnacioBecerra added the package: web components Work necessary for the IBM.com Library web components package label Dec 2, 2021
@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 2, 2021
@kodiakhq kodiakhq bot merged commit 61ea69e into carbon-design-system:master Dec 3, 2021
@ariellalgilmore ariellalgilmore mentioned this pull request Dec 3, 2021
Closed
@ariellalgilmore ariellalgilmore mentioned this pull request Sep 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@RichKummer RichKummer Awaiting requested review from RichKummer RichKummer was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IgnacioBecerra @ibmdotcom-bot @emyarod @ariellalgilmore @jeffchew