Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CTA section] Content item should not allow Button as a CTA type #7439

Closed
shixiedesign opened this issue Oct 19, 2021 · 0 comments
Closed

[CTA section] Content item should not allow Button as a CTA type #7439

shixiedesign opened this issue Oct 19, 2021 · 0 comments
Assignees
@IgnacioBecerra
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 21-24

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Oct 19, 2021 •
edited
Loading

Expected content item types are only Text, Stat, Picto, Media. No buttons in this component.
Design spec: https://ibm.box.com/s/g33w79p1lg33nxdkbf0o36dtyybaxzie

image.png
@shixiedesign shixiedesign changed the title [WIP] Content item type Button? [CTA section] Content item type Button? Oct 19, 2021
@shixiedesign shixiedesign changed the title [CTA section] Content item type Button? [CTA section] Content item should not allow Button as a CTA type Oct 21, 2021
@shixiedesign shixiedesign added bug Something isn't working dev Needs some dev work labels Oct 21, 2021
@RobertaJHahn RobertaJHahn added package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround labels Oct 26, 2021
@jeffchew jeffchew added this to the Sprint 21-24 milestone Oct 26, 2021
@IgnacioBecerra IgnacioBecerra self-assigned this Nov 22, 2021
@IgnacioBecerra IgnacioBecerra mentioned this issue Nov 30, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Dec 3, 2021
@IgnacioBecerra
fix(cta-section): ensure buttons are not allowed as cta types (#7782)
61ea69e 
### Related Ticket(s)
#7439

### Description
Currently the CTA Section story allowed Buttons as CTA types for the content items. With this new PR, I removed the ability to choose Buttons from the knob, as well as ensure that any slotted Button Group does not render if within a `cta-block-item` element.

### Changelog

**New**

- `ButtonGroup` will not rendered if used inside a `cta-block-item` element

**Removed**
- buttons option in CTA type knob for `CTASection`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IgnacioBecerra IgnacioBecerra

Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-24
Development

No branches or pull requests
4 participants
@jeffchew @shixiedesign @IgnacioBecerra @RobertaJHahn