Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale-modal): update expressive theme styles #7078

Merged
merged 7 commits into from
Sep 8, 2021
Merged

fix(locale-modal): update expressive theme styles #7078

merged 7 commits into from
Sep 8, 2021

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 7, 2021

Related Ticket(s)

#6265

Description

This PR updates the locale modal styles to match the updated expressive theme spec

image

image

Confirm that the React and web component locale modals match the expressive component spec

Changelog

Changed

  • locale modal styles
  • story formatting

@emyarod emyarod added package: styles Work necessary for the Carbon for IBM.com styles package Needs design approval PRs on feature requests and new components have to get design approval before merge. labels Sep 7, 2021
@emyarod emyarod added this to the Sprint 21-18 milestone Sep 7, 2021
@emyarod emyarod requested a review from a team as a code owner September 7, 2021 20:54
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 7, 2021 •
edited
Loading

Deploy preview created for package Web Components - Codesandbox Examples:
https://webcomponents-codesandbox.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7078/

Built with commit: 257aaba012cebefb5cd4075a5c60c37cca65ddee

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/7078/index.html

Built with commit: 257aaba012cebefb5cd4075a5c60c37cca65ddee

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7078/index.html

Built with commit: 257aaba012cebefb5cd4075a5c60c37cca65ddee

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7078/index.html

Built with commit: 257aaba012cebefb5cd4075a5c60c37cca65ddee

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7078/index.html

Built with commit: 257aaba012cebefb5cd4075a5c60c37cca65ddee

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package NextJS Test Application:
https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/7078/index.html

Built with commit: 257aaba012cebefb5cd4075a5c60c37cca65ddee

shixiedesign
shixiedesign approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@shixiedesign shixiedesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@shixiedesign shixiedesign removed the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Sep 8, 2021
jeffchew
jeffchew approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Sep 8, 2021
@kodiakhq kodiakhq bot merged commit 80c0505 into carbon-design-system:feat/expressive-sunset Sep 8, 2021
@emyarod emyarod deleted the 6265-fix/local-modal-expressive-styles branch September 8, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shixiedesign shixiedesign shixiedesign approved these changes

@jeffchew jeffchew jeffchew approved these changes

@RichKummer RichKummer Awaiting requested review from RichKummer

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra

Assignees
No one assigned
Labels
package: styles Work necessary for the Carbon for IBM.com styles package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
Sprint 21-18
Development

Successfully merging this pull request may close these issues.
4 participants
@emyarod @ibmdotcom-bot @jeffchew @shixiedesign