Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Locale modal] without expressive theme, update styles #6265

Closed
6 tasks done
oliviaflory opened this issue Jun 4, 2021 · 0 comments
Closed
6 tasks done

[Locale modal] without expressive theme, update styles #6265

oliviaflory opened this issue Jun 4, 2021 · 0 comments
Assignees
@emyarod
Labels
bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package severity 4 Affects minor functionality, no workaround needed
Milestone
Sprint 21-18

Comments

@oliviaflory
Copy link
Contributor

oliviaflory commented Jun 4, 2021 •
edited by emyarod
Loading

Detailed description

Describe in detail the issue you're having.

Removing the expressive theme changed some of the type sizes in the Locale selector.

  • update eyebrow to $body-short-02
  • update icon size to 20px

Screen Shot 2021-06-04 at 9 40 45 AM

  • update link with icon to use Large link with icon from Core carbon (if Carbon does not allow arrow icon to the left of link, we should use our Link with icon component)
  • space between search and "this page is avilable in these languages" to 32px
  • update "This page is available in these languages" to use $label-02 type token
  • update border below "This page is available in these language" to use $ui-03 color token

Screen Shot 2021-06-04 at 9 40 55 AM

Additional information

PR removing expressive
Web components
React
@oliviaflory oliviaflory added bug Something isn't working package: styles Work necessary for the Carbon for IBM.com styles package labels Jun 4, 2021
@oliviaflory oliviaflory mentioned this issue Jun 4, 2021
Closed
4 tasks
@RobertaJHahn RobertaJHahn added dev Needs some dev work severity 4 Affects minor functionality, no workaround needed priority: low and removed severity 4 Affects minor functionality, no workaround needed labels Jun 10, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-14 milestone Jun 10, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-14, Sprint 21-16 Jun 17, 2021
@RobertaJHahn RobertaJHahn added severity 4 Affects minor functionality, no workaround needed and removed priority: low labels Jul 13, 2021
@emyarod emyarod self-assigned this Sep 2, 2021
This was referenced Sep 7, 2021
Merged
Closed
kodiakhq bot pushed a commit that referenced this issue Sep 8, 2021
@emyarod
fix(locale-modal): update expressive theme styles (#7078)
80c0505 
### Related Ticket(s)

#6265

### Description

This PR updates the locale modal styles to match the updated expressive theme spec 

![image](https://user-images.githubusercontent.com/8265238/132409303-d3cbf1e7-8f61-4279-8024-803a1d5353fe.png)

![image](https://user-images.githubusercontent.com/8265238/132409330-2687f25a-d39f-4947-a637-66c993db973c.png)

Confirm that the React and web component locale modals match the expressive component spec

### Changelog

**Changed**

- locale modal styles
- story formatting

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@emyarod emyarod modified the milestones: Sprint 21-19, Sprint 21-18 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emyarod emyarod

Labels
bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package severity 4 Affects minor functionality, no workaround needed
Projects
None yet
Milestone
Sprint 21-18
Development

No branches or pull requests
9 participants
@jeffchew @emyarod @shixiedesign @ariellalgilmore @ljcarot @oliviaflory @DragosRistici @RobertaJHahn @andysherman2121