Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): remove aria-hidden from copy #5196

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#5194

Description

remove aria-hidden from copy. Reads copy text in carasoul

Changelog

Removed

  • aria-hidden: true

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 17, 2021

Copy link
Contributor

@guilhermelMoraes guilhermelMoraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ari! Thanks! 👍🏻

@guilhermelMoraes guilhermelMoraes added the Ready to merge Label for the pull requests that are ready to merge label Feb 17, 2021
@kodiakhq kodiakhq bot merged commit d1a547a into carbon-design-system:release/v1.16.0 Feb 17, 2021
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
### Related Ticket(s)

carbon-design-system#5194 

### Description

remove aria-hidden from copy. Reads copy text in carasoul

### Changelog

**Removed**

- `aria-hidden: true`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@ariellalgilmore ariellalgilmore deleted the fix/card-copy_aria branch February 25, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants