Skip to content

Commit

Permalink
fix(card): remove aria-hidden from copy (carbon-design-system#5196)
Browse files Browse the repository at this point in the history
### Related Ticket(s)

carbon-design-system#5194 

### Description

remove aria-hidden from copy. Reads copy text in carasoul

### Changelog

**Removed**

- `aria-hidden: true`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
  • Loading branch information
ariellalgilmore authored and IgnacioBecerra committed Feb 22, 2021
1 parent 1fe1ba5 commit abc4d07
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion packages/web-components/src/components/card/card.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class DDSCard extends StableSelectorMixin(BXLink) {
protected _renderCopy(): TemplateResult | string | void {
const { _hasCopy: hasCopy } = this;
return html`
<div ?hidden="${!hasCopy}" class="${prefix}--card__copy" aria-hidden="true">
<div ?hidden="${!hasCopy}" class="${prefix}--card__copy">
<slot @slotchange="${this._handleSlotChange}"></slot>
</div>
`;
Expand Down
1 change: 0 additions & 1 deletion packages/web-components/tests/snapshots/dds-card-cta.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down
2 changes: 0 additions & 2 deletions packages/web-components/tests/snapshots/dds-card.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down Expand Up @@ -50,7 +49,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down Expand Up @@ -59,7 +58,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down
2 changes: 0 additions & 2 deletions packages/web-components/tests/snapshots/dds-feature-card.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down Expand Up @@ -56,7 +55,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down
1 change: 0 additions & 1 deletion packages/web-components/tests/snapshots/dds-feature-cta.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
<slot name="heading">
</slot>
<div
aria-hidden="true"
class="bx--card__copy"
hidden=""
>
Expand Down

0 comments on commit abc4d07

Please sign in to comment.