Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(megamenu): update custom megamenu data for storybook testing #5132

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Feb 9, 2021

Related Ticket(s)

{{Provide url(s) to the related ticket(s) that this pull request addresses}}

Description

Got a request from analytics team for US homepage to update the masthead custom data so they can check the links with the new megamenu update

Changelog

New

  • updated custom links for web-components and react masthead

@annawen1 annawen1 added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package labels Feb 9, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2021

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @annawen1!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 10, 2021
@kodiakhq kodiakhq bot merged commit 5b7ff95 into carbon-design-system:master Feb 10, 2021
@annawen1 annawen1 deleted the feat/megamenu-content-update branch February 10, 2021 18:19
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
…rbon-design-system#5132)

### Related Ticket(s)

{{Provide url(s) to the related ticket(s) that this pull request addresses}}

### Description

Got a request from analytics team for US homepage to update the masthead custom data so they can check the links with the new megamenu update

### Changelog

**New**

- updated custom links for web-components and react masthead

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants