feat(megamenu): megamenu web component HC & AI updates #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: 43d0f4c5fea2d49b157f1c0dfa91a9eed70b4b9d |
|
Deploy preview created for package Built with commit: 43d0f4c5fea2d49b157f1c0dfa91a9eed70b4b9d |
|
Deploy preview created for package Built with commit: 43d0f4c5fea2d49b157f1c0dfa91a9eed70b4b9d |
annawen1
requested review from
asudoh,
jyoon25,
kennylam,
andysherman2121,
ariellalgilmore,
IgnacioBecerra,
jeffchew,
raphaelamadeu-zz and
guilhermelMoraes
annawen1
changed the title
annawen1
added
package: web components
asudoh
reviewed
Jan 28, 2021
packages/web-components/src/components/masthead/left-nav-menu-highlighted.ts
Outdated
Show resolved
Hide resolved
ariellalgilmore
approved these changes
Feb 1, 2021
ariellalgilmore
added
the
Ready to merge
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 1, 2021
### Related Ticket(s) React stand alone: Change Mega Menu HC + AI updates component #4653 ### Description **NOTE** please merge in the web components version first: #5016 as this branch is based off that one! HC & AI updates for the Megamenu You can view the changes in the `Custom Data` story under Masthead <img width="1615" alt="Screen Shot 2021-01-29 at 7 17 16 PM" src="https://user-images.githubusercontent.com/54281166/106340611-61b05900-6268-11eb-9f6c-cd51048b0abf.png"> <img width="341" alt="Screen Shot 2021-01-29 at 7 16 53 PM" src="https://user-images.githubusercontent.com/54281166/106340606-5f4dff00-6268-11eb-9644-2c82f2bc19f2.png"> ### Changelog **New** - added necessary data to the `Custom Navigation` masthead story so we can view the design updates - heading and description copy passed to `Megamenu` **Changed** - calculate how many highlighted menu items there are and set a classname to the last highlighted menu item to set border for mobile nav <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
|
@annawen1 Here's design QA for megamenu. Let me know if you have any comments. Thanks!
|
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…-system#5016) ### Related Ticket(s) Web Component: Change Mega Menu to accommodate HC + AI updates component carbon-design-system#4641 ### Description *** NOTE: The React mobile version looks broken, another PR coming to address that so I would recommend waiting for that PR before we merge this one **** Megamenu Web Components Hybrid Cloud and AI updates <img width="1642" alt="Screen Shot 2021-01-29 at 11 46 45 AM" src="https://user-images.githubusercontent.com/54281166/106303051-b1226500-6227-11eb-9e84-689665728cfe.png"> <img width="352" alt="Screen Shot 2021-01-27 at 2 04 18 PM" src="https://user-images.githubusercontent.com/54281166/106045183-a3959f80-60ae-11eb-90c0-243c740c31e0.png"> <img width="348" alt="Screen Shot 2021-01-27 at 2 04 25 PM" src="https://user-images.githubusercontent.com/54281166/106045163-9e385500-60ae-11eb-9e35-ce033a9a3d01.png"> Also created "With Custom Data" separate story for masthead so we can view how the design updates look with the expected data. ### Changelog **New** - `dds-left-nav-menu-category-heading` for the heading text (ie. The essentials) - `dds-left-nav-menu-highlighted` and `dds-left-nav-menu-item-highlighted` for highlighted mobile menu items so we can target when to add the darker bottom border - `dds-megamenu-category-group-copy` for the heading and description text in the megamenu <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
IgnacioBecerra
pushed a commit
to IgnacioBecerra/ibm-dotcom-library
that referenced
this pull request
Feb 22, 2021
…tem#5043) ### Related Ticket(s) React stand alone: Change Mega Menu HC + AI updates component carbon-design-system#4653 ### Description **NOTE** please merge in the web components version first: carbon-design-system#5016 as this branch is based off that one! HC & AI updates for the Megamenu You can view the changes in the `Custom Data` story under Masthead <img width="1615" alt="Screen Shot 2021-01-29 at 7 17 16 PM" src="https://user-images.githubusercontent.com/54281166/106340611-61b05900-6268-11eb-9f6c-cd51048b0abf.png"> <img width="341" alt="Screen Shot 2021-01-29 at 7 16 53 PM" src="https://user-images.githubusercontent.com/54281166/106340606-5f4dff00-6268-11eb-9644-2c82f2bc19f2.png"> ### Changelog **New** - added necessary data to the `Custom Navigation` masthead story so we can view the design updates - heading and description copy passed to `Megamenu` **Changed** - calculate how many highlighted menu items there are and set a classname to the last highlighted menu item to set border for mobile nav <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "package: styles": Carbon Expressive --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Web Component: Change Mega Menu to accommodate HC + AI updates component #4641
Description
*** NOTE: The React mobile version looks broken, another PR coming to address that so I would recommend waiting for that PR before we merge this one ****
Megamenu Web Components Hybrid Cloud and AI updates
Also created "With Custom Data" separate story for masthead so we can view how the design updates look with the expected data.
Changelog
New
dds-left-nav-menu-category-headingfor the heading text (ie. The essentials)dds-left-nav-menu-highlightedanddds-left-nav-menu-item-highlightedfor highlighted mobile menu items so we can target when to add the darker bottom borderdds-megamenu-category-group-copyfor the heading and description text in the megamenu