Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React stand alone: Change Mega Menu HC + AI updates component #4653

Closed
2 of 7 tasks
RobertaJHahn opened this issue Dec 7, 2020 · 0 comments
Closed
2 of 7 tasks

React stand alone: Change Mega Menu HC + AI updates component #4653

RobertaJHahn opened this issue Dec 7, 2020 · 0 comments
Assignees
@annawen1
Labels
adopter: Innovation Team used when component or pattern will be used by this adopter adopter support dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package sprint demo Sprint Must Have
Milestone
Sprint 21-03

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Dec 7, 2020 •
edited by annawen1
Loading

This development work is also scheduled for the Web Component version. The Web Component development is managed under epic (#4322)

User Story

As a [user role below]:
IBM.com Library developer

I need to:
create/change the Mega Menu

so that I can:
provide the ibm.com adopter developers components they can use to build ibm.com web pages

Additional information

Acceptance criteria

  • Built as a pure React component/variant
  • Include README for the react component and corresponding styles
  • Add any necessary stable selectors
  • Create codesandbox example under /packages/react/examples/codesandbox and include in README
  • Minimum 80% unit test coverage
  • The Storybook link is added to the Design QA issue for their testing
  • A comment is posted in the Prod QA issue, tagging Praveen, when development is finished
@RobertaJHahn RobertaJHahn added adopter support adopter: Innovation Team used when component or pattern will be used by this adopter adopter: Reboot dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package labels Dec 7, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 21-01 milestone Dec 7, 2020
@RobertaJHahn RobertaJHahn changed the title React stand alone: React stand alone: Update the Carbon mega menu to accommodate hybrid cloud + AI Dec 7, 2020
@RobertaJHahn RobertaJHahn changed the title React stand alone: Update the Carbon mega menu to accommodate hybrid cloud + AI React stand alone: Change Mega Menu HC + AI updates component Dec 7, 2020
This was referenced Dec 7, 2020
Closed
Closed
@annawen1 annawen1 self-assigned this Jan 26, 2021
@annawen1 annawen1 mentioned this issue Jan 30, 2021
Merged
kodiakhq bot pushed a commit that referenced this issue Feb 1, 2021
@annawen1
feat(Megamenu): react megamenu updates for HC & AI (#5043)
28f0b0f 
### Related Ticket(s)

React stand alone: Change Mega Menu HC + AI updates component #4653

### Description

**NOTE** please merge in the web components version first: #5016 as this branch is based off that one!

HC & AI updates for the Megamenu

You can view the changes in the `Custom Data` story under Masthead

<img width="1615" alt="Screen Shot 2021-01-29 at 7 17 16 PM" src="https://user-images.githubusercontent.com/54281166/106340611-61b05900-6268-11eb-9f6c-cd51048b0abf.png">

<img width="341" alt="Screen Shot 2021-01-29 at 7 16 53 PM" src="https://user-images.githubusercontent.com/54281166/106340606-5f4dff00-6268-11eb-9644-2c82f2bc19f2.png">


### Changelog

**New**

- added necessary data to the `Custom Navigation` masthead story so we can view the design updates
- heading and description copy passed to `Megamenu`

**Changed**

- calculate how many highlighted menu items there are and set a classname to the last highlighted menu item to set border for mobile nav

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this issue Feb 22, 2021
@annawen1 @IgnacioBecerra
feat(Megamenu): react megamenu updates for HC & AI (carbon-design-sys…
e9bed17 
…tem#5043)

### Related Ticket(s)

React stand alone: Change Mega Menu HC + AI updates component carbon-design-system#4653

### Description

**NOTE** please merge in the web components version first: carbon-design-system#5016 as this branch is based off that one!

HC & AI updates for the Megamenu

You can view the changes in the `Custom Data` story under Masthead

<img width="1615" alt="Screen Shot 2021-01-29 at 7 17 16 PM" src="https://user-images.githubusercontent.com/54281166/106340611-61b05900-6268-11eb-9f6c-cd51048b0abf.png">

<img width="341" alt="Screen Shot 2021-01-29 at 7 16 53 PM" src="https://user-images.githubusercontent.com/54281166/106340606-5f4dff00-6268-11eb-9644-2c82f2bc19f2.png">


### Changelog

**New**

- added necessary data to the `Custom Navigation` masthead story so we can view the design updates
- heading and description copy passed to `Megamenu`

**Changed**

- calculate how many highlighted menu items there are and set a classname to the last highlighted menu item to set border for mobile nav

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annawen1 annawen1

Labels
adopter: Innovation Team used when component or pattern will be used by this adopter adopter support dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package sprint demo Sprint Must Have
Projects
None yet
Milestone
Sprint 21-03
Development

No branches or pull requests
2 participants
@RobertaJHahn @annawen1