Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expressive): remove productive mixin from component styles and replace with expressive tokens #4957

Merged
merged 10 commits into from
Jan 27, 2021
Merged

fix(expressive): remove productive mixin from component styles and replace with expressive tokens #4957

merged 10 commits into from
Jan 27, 2021

Conversation

annawen1
Copy link
Member

Related Ticket(s)

Remove productive mixin & apply expressive tokens to Carbon for IBM.com components #4748

Description

Remove productive mixin from components (leave as is in the masthead) styles and replace with expressive tokens

Changelog

Changed

  • swap tokens with expressive tokens

Removed

  • unused card video footer styles
  • edit the LogoGrid card props to set card heading as intended from the LogoGrid design specs (https://ibm.ent.box.com/file/661851053906)
  • productive token mixin use from components other than masthead

@annawen1 annawen1 added package: carbon web components package: react Work necessary for the Carbon for IBM.com react components package package: styles Work necessary for the Carbon for IBM.com styles package and removed package: carbon web components package: react Work necessary for the Carbon for IBM.com react components package labels Jan 21, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4957/index.html

Built with commit: 879f99b6bbcbda5512e2fe8a9778109d2ebfd607

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4957/index.html

Built with commit: 879f99b6bbcbda5512e2fe8a9778109d2ebfd607

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021 •
edited
Loading

Deploy preview created for package "Carbon Expressive":
https://carbon-expressive.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4957/index.html

Built with commit: 879f99b6bbcbda5512e2fe8a9778109d2ebfd607

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4957/index.html

Built with commit: 879f99b6bbcbda5512e2fe8a9778109d2ebfd607

@annawen1 annawen1 requested a review from oliviaflory January 21, 2021 19:26
@oliviaflory
Copy link
Contributor

Adding from slack just for record

Looks great! The only one that’s weird is the Leaving IBM in the react wrapper storybook.
“The link you requested…” text is bigger than in the Web Component. That could be a separate thing though?

Screen Shot 2021-01-22 at 5 25 16 PM

oliviaflory
oliviaflory approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Jan 25, 2021
@kodiakhq kodiakhq bot merged commit 1e14abe into carbon-design-system:master Jan 27, 2021
@jeffchew jeffchew mentioned this pull request Feb 1, 2021
Closed
@annawen1 annawen1 deleted the fix/remove-productive-tokens branch February 10, 2021 18:19
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@annawen1 @IgnacioBecerra
fix(expressive): remove productive mixin from component styles and re…
07b3c79 
…place with expressive tokens (carbon-design-system#4957)

### Related Ticket(s)

Remove productive mixin & apply expressive tokens to Carbon for IBM.com components carbon-design-system#4748

### Description

Remove productive mixin from components (leave as is in the masthead) styles and replace with expressive tokens

### Changelog

**Changed**

- swap tokens with expressive tokens

**Removed**

- unused card video footer styles
- edit the LogoGrid card props to set card heading as intended from the LogoGrid design specs (https://ibm.ent.box.com/file/661851053906)
- productive token mixin use from components other than masthead

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviaflory oliviaflory oliviaflory approved these changes

Assignees
No one assigned
Labels
package: styles Work necessary for the Carbon for IBM.com styles package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawen1 @ibmdotcom-bot @oliviaflory @jeffchew